From owner-freebsd-gnome@FreeBSD.ORG Thu Nov 27 21:24:22 2014 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3251BE5B for ; Thu, 27 Nov 2014 21:24:22 +0000 (UTC) Received: from mail-lb0-x22b.google.com (mail-lb0-x22b.google.com [IPv6:2a00:1450:4010:c04::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A55DBF67 for ; Thu, 27 Nov 2014 21:24:21 +0000 (UTC) Received: by mail-lb0-f171.google.com with SMTP id n15so4754335lbi.16 for ; Thu, 27 Nov 2014 13:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=m5LjmTZiVTlr56nJURF4Lp/s4hyjadzq+hjdIQawGYg=; b=K0V+5KJ8aIMk6b3a0tLt68fmdPAZi/VKQiuXPyQVYqB6MzlgyKgqqYIqfvVm7PLDkU vEM0VITUE33nONj2FCDVQUbbDl9wbv3W0d0vFxtVckExC+tNugJ59gMfs6ihmE6zDkDT Wg4RT9bp//OssP0eEguQEl9laI9L4Wpkb/Qxc/NccP1zWzrEGJ4LfXDp50e+KKalCi71 1gh8Ozmb93zMWQMgpk1XvGvob/iMubJjdeUd26VDrCthBSqb3tVFKQ6YczXt7Mk+BF+u y4qNtBYzy4GZnFoWupuRw6bk9aNY5A1+InOBcpeJo8FbFg42K1BQYIJVkk+CowH/zW4V 2flA== MIME-Version: 1.0 X-Received: by 10.112.150.71 with SMTP id ug7mr40809114lbb.73.1417123459634; Thu, 27 Nov 2014 13:24:19 -0800 (PST) Received: by 10.152.185.197 with HTTP; Thu, 27 Nov 2014 13:24:19 -0800 (PST) In-Reply-To: References: <20140916124035.2217ba67f72bce56e56eb677@3dresearch.com> <546F767B.4070702@missouri.edu> <20141125080248.GA1026@medusa.sysfault.org> Date: Thu, 27 Nov 2014 21:24:19 +0000 Message-ID: Subject: Re: /usr/ports/devel/py-gobject3: typo? From: isdtor To: freebsd-gnome@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 21:24:22 -0000 Not only does this affect gnome, but it also affects mate, through x11/mate-applets. On 25 November 2014 at 19:43, Antoine Brodin wrote: > On Tue, Nov 25, 2014 at 9:02 AM, Marcus von Appen wrote: >> On, Tue Nov 25, 2014, Antoine Brodin wrote: >> >>> On Tue, Nov 25, 2014 at 5:38 AM, Jia-Shiun Li wrote: >>> > See if this is helpful to you.. >>> > >>> > I encountered this in the middle of building gnome3-lite. On my case >>> > py-gobject3 builds fine alone but fails if built as dependency. >>> > >>> > When failing, there is no >>> > pygobject-3.14.0-py2.7-freebsd-11.0-CURRENT-amd64.egg-info >>> > as requested in install phase, but there does have >>> > pygobject-3.14.0-pypython2.7-freebsd-11.0-CURRENT-amd64.egg-info >>> > in the directory. looks something messed up PYTHON_VER for plist. >>> > >>> > >>> > The easier way to reproduce is >>> > cd /usr/ports/accessibility/caribou && make >>> > vs. >>> > cd /usr/ports/devel/py-gobject3 && make install >>> > >>> > config.log files from both do not differ. It is more likely 'make >>> > install' causing the problem. >>> > >>> > >>> > My temporary workaround is to rename the file as plist required and continue. >>> >>> Hi mva@, >>> >>> Could you have a look at this? >>> I believe that the DEPENDS_ARGS+=PYTHON_VERSION=${PYTHON_VERSION} in >>> python.mk can cause this kind of issue for some autoconf based >>> projects. >>> In python.mk, PYTHON_VERSION=python2.7, but in some autoconf based >>> projects PYTHON_VERSION=2.7 (${PYTHON} -c "import sys; >>> sys.stdout.write(sys.version[:3])" 2>/dev/null) >>> So the DEPEND_ARGS may pollute the build of dependencies... >> >> Yes, it looks like DEPENDS_ARGS is the culprit here. The conditionals >> within the configure script of pygobject3-common can run into >> situations, where they do not override PYTHON_VERSION properly. >> >> We have two ways around that: >> >> - override PYTHON_VERSION in the individual ports, which break that way >> - quickly done >> - has to be done on a port-per-port basis >> - adds another "hack" to maintain per port >> - rename PYTHON_VERSION in the ports infrastructure to something else >> - more clean approach(?) >> - not done quickly >> - may affect users using PYTHON_VERSION actively >> - may need other ports to receive additional changes >> - needs a full exp-run (without isolations, so poudriere is a no-op) >> >> As workaround, I'd go with the first option for now. Depending on how >> the gnome stuff evolves, we may need to look into option two as well. > > > The attached patch is ugly, but it seems to work. > I agree that long term solution would be to use variable names that > don't pollute ports build in DEPENDS_ARGS. > > Cheers, > > Antoine > > _______________________________________________ > freebsd-gnome@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-gnome > To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org"