Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Nov 2015 01:56:48 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 204725] |make makepatch| inserts context junk after r401709
Message-ID:  <bug-204725-13-C0mi8DPiAh@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204725-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-204725-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204725

--- Comment #4 from John Marino <marino@FreeBSD.org> ---
There were two issues.

1) The last minute add of "local" keyword broke makepatch.  I don't know why,
but some of the "local var=$(some cmd)" didn't work.  I had to change them to:
local var
var=$(some cmd)

2) The hunk processing had a logic flaw.

Please try the attached patch.
I think it works.

(It results in one less patch at the end because one patch changed a file that
had been altered by another another patch.  When this happens, the changes get
combined and this is expected)

-- 
You are receiving this mail because:
You are on the CC list for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204725-13-C0mi8DPiAh>