From nobody Fri Jul 31 12:37:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBQZB1ms2z6mhrD for ; Fri, 31 Jul 2026 12:37:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBQZ96cVPz3MyZ for ; Fri, 31 Jul 2026 12:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785501442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PgqFGfXB4Qpl5bZVK6do/LnBsAA8+/OFWIF61NoU/m8=; b=ihjOSSGzSNSkiPJNqkmvyyVKbqWeGkXzvKDcL8ygp4O7z+DrZF59D429eTFLQGouxHFZdS JRtqWkxCqRQ5WhlOarPxkI3UKeIoatJy/ZuWOr21tDH80Zw4fMMvypvqmCuNjewxCXl096 mlxuQeTkWZnXa/IrNQ4ZbQpRyvb0KfuDU0ZVErHDccGT+zMzmJtyGfK7n06XWtF/tSeigL rnxwn6azbE3jWnMQWFySxt3mrgWcliOCzuHmP4/OqoM/jz0rkWLR0Tg6LoMy7A6aMguEVb XnZ4Bjya9MFQM3iJdfeO15oh1f9hvHi1xbt3SX4NyZem4zgk9l1EGgEgXrCtwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785501442; a=rsa-sha256; cv=none; b=fCZs9Mz4q9fMjgGqWq8Opk3Ne4TTZhVSIFt4ojsOkYC+J//SDuzg7jHgBDlBH6kuQaSTch fVpMCLOomFQWQW+iqEnn64XixQ1R9UwkdHGiRCJBXeQazcKMZCAg/NLgYrXsb0s7B3DAjr KbakUhgW4Fz69iINxIYgbIdQFUFgpqJg7zx/Ohe8Dny9luVegZJashffkEjuVRR2XOt6NI yjWl93zbWK8FNXEfm8fMsSLuneF3j7ZxJCq6no4liPyDPQ1fcfuhB+/qbb7CHo9W9Nh/Kb b7ro4qQKtWO2ErZQKEqAW7zo0ATQ5udHZZPAbbLftZHzHJWEmQ/6Z1RtSc8Y5Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785501442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PgqFGfXB4Qpl5bZVK6do/LnBsAA8+/OFWIF61NoU/m8=; b=EF1Lmu7Q8r6FRuNrUJ/SUwAPk2RbEiu4H5Wdy2uHIYpe+hL3uL+ROHkv5EqVtyy3pC7vMq +Vujs5LX92xWDkKuMJszTQK3cXJpcKYwZDjpEgk6i6olawnfI9CYSc7rEiMaQOFmuL88fD iP55D8EFHGw2vDr3qJGF+FRrOQ2Ns3XaSEtTzdVZc1wSovNElfgIlUathATZNodTzUwIZw oB1FrZnnB+KGwFcfHwlH0rsApyjFnaAcDGrNOWikV6BLW64MyV78reo/xdNe2gMZzfAFJo TAW44ypD+i+ipnotlI5oGTKd6hm0m/XqEPjixR4It1xJF4OU519THVZHYlClRw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBQZ95d20z10Fc for ; Fri, 31 Jul 2026 12:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44c0f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 12:37:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 5bb8119150d2 - main - ifconfig: Add netlink support for gif(4) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5bb8119150d2f52c4d4fc0f1935592c554681964 Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 12:37:21 +0000 Message-Id: <6a6c9701.44c0f.5289d424@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=5bb8119150d2f52c4d4fc0f1935592c554681964 commit 5bb8119150d2f52c4d4fc0f1935592c554681964 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-07-08 19:18:00 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-07-31 12:36:46 +0000 ifconfig: Add netlink support for gif(4) This implementation does not cover tunnel addresses. Differential Revision: https://reviews.freebsd.org/D57667 --- sbin/ifconfig/ifgif.c | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 194 insertions(+) diff --git a/sbin/ifconfig/ifgif.c b/sbin/ifconfig/ifgif.c index 9b8be210a59e..a8af8389bcc2 100644 --- a/sbin/ifconfig/ifgif.c +++ b/sbin/ifconfig/ifgif.c @@ -36,7 +36,9 @@ #include #include #include +#ifdef WITHOUT_NETLINK #include +#endif #include #include @@ -48,11 +50,195 @@ #include "ifconfig.h" +#ifndef WITHOUT_NETLINK +#include "ifconfig_netlink.h" +#endif + static const char *GIFBITS[] = { [0] = "NOCLAMP", [1] = "IGNORE_SOURCE", }; +#ifndef WITHOUT_NETLINK +struct nl_parsed_gif { + uint32_t ifla_flags; +}; + +struct nla_gif_info { + const char *kind; + struct nl_parsed_gif data; +}; + +struct nla_gif_link { + uint32_t ifi_index; + struct nla_gif_info linkinfo; +}; + +static inline void +gif_nl_init(if_ctx *ctx, struct snl_writer *nw, uint32_t flags) +{ + struct nlmsghdr *hdr; + + snl_init_writer(ctx->io_ss, nw); + hdr = snl_create_msg_request(nw, NL_RTM_NEWLINK); + hdr->nlmsg_flags |= flags; + snl_reserve_msg_object(nw, struct ifinfomsg); + snl_add_msg_attr_string(nw, IFLA_IFNAME, ctx->ifname); +} + +static inline void +gif_nl_fini(if_ctx *ctx, struct snl_writer *nw) +{ + struct nlmsghdr *hdr; + struct snl_errmsg_data errmsg = {}; + + hdr = snl_finalize_msg(nw); + if (hdr == NULL || !snl_send_message(ctx->io_ss, hdr)) + err(1, "unable to send netlink message"); + + if (!snl_read_reply_code(ctx->io_ss, hdr->nlmsg_seq, &errmsg)) + errx(errmsg.error, "%s", errmsg.error_str); +} + +#define _OUT(_field) offsetof(struct nl_parsed_gif, _field) +static const struct snl_attr_parser nla_p_gif[] = { + { .type = IFLA_IPTUN_FLAGS, .off = _OUT(ifla_flags), .cb = snl_attr_get_uint32 }, +}; +#undef _OUT +SNL_DECLARE_ATTR_PARSER(gif_linkinfo_data_parser, nla_p_gif); + +#define _OUT(_field) offsetof(struct nla_gif_info, _field) +static const struct snl_attr_parser ap_gif_linkinfo[] = { + { .type = IFLA_INFO_KIND, .off = _OUT(kind), .cb = snl_attr_get_string }, + { .type = IFLA_INFO_DATA, .off = _OUT(data), + .arg = &gif_linkinfo_data_parser, .cb = snl_attr_get_nested }, +}; +#undef _OUT +SNL_DECLARE_ATTR_PARSER(gif_linkinfo_parser, ap_gif_linkinfo); + +#define _IN(_field) offsetof(struct ifinfomsg, _field) +#define _OUT(_field) offsetof(struct nla_gif_link, _field) +static const struct snl_attr_parser ap_gif_link[] = { + { .type = IFLA_LINKINFO, .off = _OUT(linkinfo), + .arg = &gif_linkinfo_parser, .cb = snl_attr_get_nested }, +}; + +static const struct snl_field_parser fp_geneve_link[] = { + { .off_in = _IN(ifi_index), .off_out = _OUT(ifi_index), + .cb = snl_field_get_uint32 }, +}; +#undef _IN +#undef _OUT +SNL_DECLARE_PARSER(gif_parser, struct ifinfomsg, fp_geneve_link, ap_gif_link); + +static const struct snl_hdr_parser *all_parsers[] = { + &gif_linkinfo_data_parser, + &gif_linkinfo_parser, + &gif_parser, +}; + +static void +gif_status_nl(if_ctx *ctx) +{ + struct snl_writer nw; + struct nlmsghdr *hdr; + struct snl_errmsg_data errmsg = {}; + struct nla_gif_link gif_link; + + if (strncmp(ctx->ifname, "gif", sizeof("gif") - 1) != 0) + return; + + snl_init_writer(ctx->io_ss, &nw); + hdr = snl_create_msg_request(&nw, NL_RTM_GETLINK); + hdr->nlmsg_flags |= NLM_F_DUMP; + snl_reserve_msg_object(&nw, struct ifinfomsg); + snl_add_msg_attr_string(&nw, IFLA_IFNAME, ctx->ifname); + + hdr = snl_finalize_msg(&nw); + if (hdr == NULL || !snl_send_message(ctx->io_ss, hdr)) + err(1, "unable to send netlink message"); + + hdr = snl_read_reply(ctx->io_ss, hdr->nlmsg_seq); + if (hdr->nlmsg_type != NL_RTM_NEWLINK) { + if (!snl_parse_errmsg(ctx->io_ss, hdr, &errmsg)) + errx(EINVAL, "(NETLINK)"); + if (errmsg.error_str != NULL) + errx(errmsg.error, "(NETLINK) %s", errmsg.error_str); + } + + if (!snl_parse_nlmsg(ctx->io_ss, hdr, &gif_parser, &gif_link)) + return; + + struct nla_gif_info gif_info = gif_link.linkinfo; + struct nl_parsed_gif gif_data = gif_info.data; + + if (gif_data.ifla_flags == 0) + return; + + printf("\toptions=%x", gif_data.ifla_flags); + print_bits("options", &gif_data.ifla_flags, 1, GIFBITS, nitems(GIFBITS)); + putchar('\n'); +} + +static void +setgifopts_nl(if_ctx *ctx, const char *val __unused, int d) +{ + struct snl_writer nw = {}; + struct nlmsghdr *hdr; + struct snl_errmsg_data errmsg = {}; + struct nla_gif_link gif_link = {}; + int off, off2; + + snl_init_writer(ctx->io_ss, &nw); + hdr = snl_create_msg_request(&nw, NL_RTM_GETLINK); + hdr->nlmsg_flags |= NLM_F_DUMP; + snl_reserve_msg_object(&nw, struct ifinfomsg); + snl_add_msg_attr_string(&nw, IFLA_IFNAME, ctx->ifname); + + hdr = snl_finalize_msg(&nw); + if (hdr == NULL || (!snl_send_message(ctx->io_ss, hdr))) + err(1, "unable to send netlink message"); + + hdr = snl_read_reply(ctx->io_ss, hdr->nlmsg_seq); + if (hdr->nlmsg_type != NL_RTM_GETLINK) { + if (!snl_parse_errmsg(ctx->io_ss, hdr, &errmsg)) + errx(EINVAL, "(NETLINK)"); + if (errmsg.error_str != NULL) + errx(errmsg.error, "(NETLINK) %s", errmsg.error_str); + } + + if (!snl_parse_nlmsg(ctx->io_ss, hdr, &gif_parser, &gif_link)) + return; + + struct nla_gif_info gif_info = gif_link.linkinfo; + struct nl_parsed_gif gif_data = gif_info.data; + + if (d < 0) + gif_data.ifla_flags &= ~(-d); + else + gif_data.ifla_flags |= d; + + gif_nl_init(ctx, &nw, 0); + off = snl_add_msg_attr_nested(&nw, IFLA_LINKINFO); + snl_add_msg_attr_string(&nw, IFLA_INFO_KIND, "gif"); + + off2 = snl_add_msg_attr_nested(&nw, IFLA_INFO_DATA); + snl_add_msg_attr_u32(&nw, IFLA_IPTUN_FLAGS, gif_data.ifla_flags); + + snl_end_attr_nested(&nw, off2); + snl_end_attr_nested(&nw, off); + + gif_nl_fini(ctx, &nw); +} + +static struct cmd gif_cmds[] = { + DEF_CMD("noclamp", GIF_NOCLAMP, setgifopts_nl), + DEF_CMD("-noclamp", -GIF_NOCLAMP, setgifopts_nl), + DEF_CMD("ignore_source", GIF_IGNORE_SOURCE, setgifopts_nl), + DEF_CMD("-ignore_source", -GIF_IGNORE_SOURCE, setgifopts_nl), +}; + +#else static void gif_status(if_ctx *ctx) { @@ -96,11 +282,16 @@ static struct cmd gif_cmds[] = { DEF_CMD("ignore_source", GIF_IGNORE_SOURCE, setgifopts), DEF_CMD("-ignore_source", -GIF_IGNORE_SOURCE, setgifopts), }; +#endif /* !WITHOUT_NETLINK */ static struct afswtch af_gif = { .af_name = "af_gif", .af_af = AF_UNSPEC, +#ifndef WITHOUT_NETLINK + .af_other_status = gif_status_nl, +#else .af_other_status = gif_status, +#endif }; static __constructor void @@ -111,4 +302,7 @@ gif_ctor(void) for (i = 0; i < nitems(gif_cmds); i++) cmd_register(&gif_cmds[i]); af_register(&af_gif); +#ifndef WITHOUT_NETLINK + SNL_VERIFY_PARSERS(all_parsers); +#endif }