From owner-freebsd-hackers Mon Jun 24 5:41:32 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from hardtime.linuxman.net (hardtime.linuxman.net [66.147.26.65]) by hub.freebsd.org (Postfix) with ESMTP id D177C37B42F for ; Mon, 24 Jun 2002 05:40:51 -0700 (PDT) Received: from mortis.over-yonder.net (localhost [127.0.0.1]) by hardtime.linuxman.net (8.11.6/8.11.6) with ESMTP id g5OBlNB18273; Mon, 24 Jun 2002 06:47:23 -0500 Received: by mortis.over-yonder.net (Postfix, from userid 100) id 3F0491F05; Mon, 24 Jun 2002 07:40:39 -0500 (CDT) Date: Mon, 24 Jun 2002 07:40:39 -0500 From: "Matthew D. Fuller" To: Terry Lambert Cc: Paul Herman , "Geoffrey C. Speicher" , freebsd-hackers@FreeBSD.ORG Subject: Re: bug in pw, -STABLE [patch] Message-ID: <20020624124039.GB59373@over-yonder.net> References: <20020623111412.V38509-100000@mammoth.eat.frenchfries.net> <3D1662CC.FE6F6D49@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D1662CC.FE6F6D49@mindspring.com> User-Agent: Mutt/1.4i-fullermd.1 X-Editor: vi X-OS: FreeBSD Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 23, 2002 at 05:07:40PM -0700 I heard the voice of Terry Lambert, and lo! it spake thus: > > The problem with your proposed patch is that it breaks the > ability to allow authentication against the database while > it is undergoing modification, which may be a prolonged period. Would it? For starters, this locks master.passwd, not spwd.db, so any well-behaved program that used getpw*() like a good little monkey wouldn't even notice it. In fact, with Paul's change and the rename() alteration, it'd be BETTER for programs that tried to parse master.passwd, because as it currently stands, there are times when it's incomplete (because of the line-by-line copy, which caused us both a few moments of illness when we noticed it). -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ "The only reason I'm burning my candle at both ends, is because I haven't figured out how to light the middle yet" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message