From owner-svn-ports-all@freebsd.org Sat Aug 11 10:15:33 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 519451065965; Sat, 11 Aug 2018 10:15:33 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 03B1E74A67; Sat, 11 Aug 2018 10:15:33 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 3D2F6EDE9; Sat, 11 Aug 2018 10:15:32 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Sat, 11 Aug 2018 12:15:27 +0200 From: Mathieu Arnold To: Niclas Zeising Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r476508 - head/x11/xorgproto Message-ID: <20180811101527.ouegokeqq2nefjw3@atuin.in.mat.cc> References: <201808061220.w76CKd8v046156@repo.freebsd.org> <712db841-43a3-96be-8c6c-579084b9b8c9@freebsd.org> <35056151-dab2-62d1-fe39-0ecc4533a94c@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="se3mm4n6sxyliaft" Content-Disposition: inline In-Reply-To: <35056151-dab2-62d1-fe39-0ecc4533a94c@freebsd.org> User-Agent: NeoMutt/20180716 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Aug 2018 10:15:33 -0000 --se3mm4n6sxyliaft Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 11, 2018 at 11:33:13AM +0200, Niclas Zeising wrote: > On 08/11/18 11:23, Niclas Zeising wrote: > > On 08/06/18 14:20, Mathieu Arnold wrote: > > > Author: mat > > > Date: Mon Aug=A0 6 12:20:39 2018 > > > New Revision: 476508 > > > URL: https://svnweb.freebsd.org/changeset/ports/476508 > > >=20 > > > Log: > > > =A0=A0 Fix Xprint build issue. > > > =A0=A0 For some reason, the Xprint.man patch is supposed to get into a > > > subdirectory > > > =A0=A0 that does not exist: > > > =A0=A0=A0=A0 -------------------------- > > > =A0=A0=A0=A0 |--- man/Xprint.man.orig=A0=A0=A0 2018-07-24 10:46:56 UTC > > > =A0=A0=A0=A0 |+++ man/Xprint.man > > > =A0=A0=A0=A0 -------------------------- > > > =A0=A0=A0=A0 (Creating file Xprint.man...) > > > =A0=A0=A0=A0 Patching file Xprint.man using Plan A... > > > =A0=A0=A0=A0 Empty context always matches. > > > =A0=A0=A0=A0 Hunk #1 succeeded at 1. > > > =A0=A0=A0=A0 done > > > =A0=A0 So patch extracts it in the first existing directory, and then > > > the build fails: > > > =A0=A0=A0=A0 make[1]: don't know how to make man/Xprint.7. Stop > > > =A0=A0=A0=A0 make[1]: stopped in > > > /wrkdirs/usr/ports/x11/xorgproto/work/xorgproto-2018.4 > > > =A0=A0=A0=A0 *** Error code 1 > > > =A0=A0=A0=A0 Stop. > > > =A0=A0 Sponsored by:=A0=A0=A0 Absolight > > >=20 > > > Modified: > > > =A0=A0 head/x11/xorgproto/Makefile=A0=A0 (contents, props changed) > > >=20 > > > Modified: head/x11/xorgproto/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > >=20 > > > --- head/x11/xorgproto/Makefile=A0=A0=A0 Mon Aug=A0 6 11:23:41 2018= =A0=A0=A0 (r476507) > > > +++ head/x11/xorgproto/Makefile=A0=A0=A0 Mon Aug=A0 6 12:20:39 2018= =A0=A0=A0 (r476508) > > > @@ -14,4 +14,7 @@ CONFIGURE_ARGS=3D --without-fop \ > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 --without-xsltproc \ > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 --enable-legacy > > > +pre-patch: > > > +=A0=A0=A0 @${MKDIR} ${WRKSRC}/man > > > + > > > =A0 .include > > >=20 > >=20 > > Strangely, I've never ran into this issue.=A0 I created the patch point= ing > > to the directory, and it gets extracted, built and installed fine.=A0 A= re > > there differences in how patch handles nonexistent directories on > > dfifferent versions of FreeBSD? >=20 >=20 > Hi! > So, I just tried some more, in a bunch of different versions. In all my > jails, with poudriere, the man directory gets created and the patch is > extracted there as it should be. How are you building the port/package? > I'm just curious as to why we see this different behavior. This went > through an exp-run without issue, but something strange is happening here. > Regards Mmmm, the only difference with my test builds is that I have PATCH_DEBUG set. I could not understand why this was happening, and creating the directory fixed the problem, so, I took the easy path and applied the band-aid. --=20 Mathieu Arnold --se3mm4n6sxyliaft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltutz9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhK9hAAkv5taqzdhHVHsXYXjktkb1C1POXk4OvvA9WfPW46eMgGd8qFwycSwoj+ Be4puRsmtTWk6CPuVLYEKl3fNrBWelJVTXf78MbHhtb7pNje1TKVmWv/95ihsnMp 7FsUwKNQfep+7nQ0J7FDKp/03uUfqK1ZDF7NHZfJqc2Y8DmQxOozXjCF2lgR8BPN MSfMBH3mqGrs7m78HMIxecl63Wwm4Cdee5/Kmw2LW/bL+rl2OT9Sxbbh5uxqhfOE IJ136Row3lq9lYKDuXrstCDirwQTBFa0MVLGi/onwdfCiNKINtFsqoyJ6+khvIvR 99zl9GsHCrMgreoNU1Zic9tgTSWfGjcLkphtjd/VbeG9Yp/dqpTEr4lFyji36TqU q6a2iWZ5rVW8QkRuT+LtReRlyrzb/7hRHGJpNbVJQXML6p/ZgzA9ansVWryvaQR0 mIgZHBDTwQGYxwJ9rhY8Xf2ECYFaveDh8Kd4IfLVC07vctSewJtidFqTLg5gzeCr c357Lr8l6djs82gold+MFgsbN15FsV5LWDBeFwChJGLGr+DzrvtETFH/Cvt0t0nq BbKdyWDH6tyyFBKGCofIiwUapk2H3vKaUTXz67cfdtXqRQhEcg2P+vw+RB2yAdq7 REhBqpwcsvKHpp8bP05y1Zc4bXfjSfrUQY4EHAOjyWgpx7oDy/g= =W8G1 -----END PGP SIGNATURE----- --se3mm4n6sxyliaft--