From owner-svn-ports-head@freebsd.org  Sat Jul 14 20:39:22 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F58B103D41D;
 Sat, 14 Jul 2018 20:39:22 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (unknown [IPv6:2607:f440::d144:242])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BC31D88B3A;
 Sat, 14 Jul 2018 20:39:21 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (localhost [127.0.0.1])
 by ainaz.pair.com (Postfix) with ESMTP id 72417B53E06;
 Sat, 14 Jul 2018 16:39:15 -0400 (EDT)
Received: from anthias (vie-188-118-240-174.dsl.sil.at [188.118.240.174])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id 328C9B53E05;
 Sat, 14 Jul 2018 16:39:14 -0400 (EDT)
Date: Sat, 14 Jul 2018 22:39:11 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Dmitry Marakasov <amdmi3@FreeBSD.org>
cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r470444 - head/lang/gcc-ecj45
In-Reply-To: <201805200904.w4K94BAh007929@repo.freebsd.org>
Message-ID: <alpine.LSU.2.21.1807142237341.5444@anthias.pfeifer.com>
References: <201805200904.w4K94BAh007929@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2018 20:39:22 -0000

On Sun, 20 May 2018, Dmitry Marakasov wrote:
> Author: amdmi3
> Date: Sun May 20 09:04:10 2018
> New Revision: 470444
> URL: https://svnweb.freebsd.org/changeset/ports/470444
> 
> Log:
>   - Add LICENSE
>   - Cosmetic fixes
>   - Add NO_ARCH
>   
>   Approved by:	portmgr blanket

I'm not really sure "cosmetic fixes" are covered by portmgr
blanket, especially where something is a style issue.

For example...

> Modified: head/lang/gcc-ecj45/Makefile
> ==============================================================================
> -EXTRACT_SUFX=
> -EXTRACT_ONLY=
> +EXTRACT_SUFX=	# empty
> +EXTRACT_ONLY=	# empty

...I preferred the original version of that and do not see this
as a real improvement.

> +LICENSE=	EPL

> +NO_ARCH=	yes

Thanks for adding these two, on the other hand.

Gerald