From owner-svn-src-all@freebsd.org Mon Jun 17 09:29:51 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7B3915B2A6C; Mon, 17 Jun 2019 09:29:51 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E0E8487016; Mon, 17 Jun 2019 09:29:50 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x5H93WGb008132; Mon, 17 Jun 2019 02:03:32 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x5H93Wac008131; Mon, 17 Jun 2019 02:03:32 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201906170903.x5H93Wac008131@gndrsh.dnsmgr.net> Subject: Re: svn commit: r349133 - head/share/man/man4 In-Reply-To: <52998167-2193-20da-2b54-29d0862a036d@freebsd.org> To: Niclas Zeising Date: Mon, 17 Jun 2019 02:03:32 -0700 (PDT) CC: Benjamin Kaduk , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: E0E8487016 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 09:29:51 -0000 > On 2019-06-17 09:56, Benjamin Kaduk wrote: > > On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising > > wrote: > > > > Author: zeising (doc,ports committer) > > Date: Mon Jun 17 05:41:47 2019 > > New Revision: 349133 > > URL: https://svnweb.freebsd.org/changeset/base/349133 > > > > Log: > > ? pci(4): Document PCIOCATTACHED > > > > ? Document the PCIOCATTACHED ioctl(2) in the pci(4) manual. > > ? PCIOCATTACHED is used to query if a driver has attached to a PCI. > > > > ? Reviewed by:? bcr, imp > > ? MFC after:? ? 2 weeks > > ? Differential Revision: https://reviews.freebsd.org/D20652 > > > > Modified: > > ? head/share/man/man4/pci.4 > > > > Modified: head/share/man/man4/pci.4 > > ============================================================================== > > --- head/share/man/man4/pci.4? ?Mon Jun 17 03:48:44 2019 > > (r349132) > > +++ head/share/man/man4/pci.4? ?Mon Jun 17 05:41:47 2019 > > (r349133) > > @@ -24,7 +24,7 @@ > > ?.\" > > ?.\" $FreeBSD$ > > ?.\" > > -.Dd June 14, 2018 > > +.Dd June 17, 2019 > > ?.Dt PCI 4 > > ?.Os > > ?.Sh NAME > > @@ -333,6 +333,26 @@ The limitations on data width described for > > ?reading registers, above, also apply to writing > > ?.Tn PCI > > ?configuration registers. > > +.It PCIOCATTACHED > > +This > > +.Xr ioctl 2 > > +allows users to query if a driver is attached to the > > +.Tn PCI > > +specified in the passed-in > > > > > > Is there a missing word like "device" here? Actally I think the missing word, in both cases, is register, unless I am misreading some part of the manual page and what a struct pci_io points at. I guess if the pi_reg is null then this would be device. Either way there is defanity a missing word. > > I just followed the same syntax as for the PCIOCWRITE ioctl in the > paragraph before. Probably a mistake there too. > I found it a little strange when I read it, but I > kind of assumed there was a reason it said PCI and not PCI device, > perhaps similar to using RAM instead of RAM memory, if you understand > what I mean. RAM memory == Random Access Memory Memory PCI == Peripheral Component Interconnect PCI {Register, Device, Bus} all make valid sense, PCI alone does not. > Regards > Niclas > > > > > +.Va pci_io > > +structure. > > +The > > +.Va pci_io > > +structure is described above, however, the > > +.Va pi_reg > > +and > > +.Va pi_width > > +fields are not used. > > +The status of the device is stored in the > > +.Va pi_data > > +field. > > +A value of 0 indicates no driver is attached, while a value larger > > than 0 > > +indicates that a driver is attached. > > ?.It PCIOCBARMMAP > > ?This > > ?.Xr ioctl 2 > > > -- > Niclas Zeising > > > -- Rod Grimes rgrimes@freebsd.org