From owner-freebsd-ports@FreeBSD.ORG Wed Dec 17 23:46:05 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9395D16A4CE; Wed, 17 Dec 2003 23:46:05 -0800 (PST) Received: from geekpunk.net (adsl-19-197-182.bna.bellsouth.net [68.19.197.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 751F843D2D; Wed, 17 Dec 2003 23:46:03 -0800 (PST) (envelope-from bandix@geekpunk.net) Received: from localhost.my.domain (taran [127.0.0.1]) by geekpunk.net (8.12.8p1/8.12.6) with ESMTP id hBI7kEYm008580; Thu, 18 Dec 2003 01:46:14 -0600 (CST) (envelope-from bandix@geekpunk.net) Received: (from bandix@localhost) by localhost.my.domain (8.12.8p1/8.12.8/Submit) id hBI7kDix008577; Thu, 18 Dec 2003 01:46:13 -0600 (CST) Date: Thu, 18 Dec 2003 01:46:13 -0600 From: "Brandon D. Valentine" To: nc-rotherdo@netcologne.de Message-ID: <20031218074613.GA8284@geekpunk.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i cc: freebsd-gnome@freebsd.org cc: FreeBSD Ports Subject: prying x11-wm/wmakerconf loose from gnome X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2003 07:46:05 -0000 TO Dominik (wmakerconf maintainer), freebsd-ports (gnome2wmaker maintainer), and freebsd-gnome, My apologies for the crosspost, but I'm looking for some advice on eliminating this: % pkg_info -r wmakerconf-2.8.1 | wc -l 68 The wmakerconf port does not require gnome, except that it does. The Makefile for wmakerconf contains this: [...] USE_GNOME= imlib WANT_GNOME= yes [...] .if defined(HAVE_GNOME) BUILD_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker RUN_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker PLIST_SUB+= GNOME:="" .else PLIST_SUB+= GNOME:="@comment " .endif [...] '.if defined(HAVE_GNOME)' will always evaluate to true as the port has just declared its dependency on imlib above. Thus, wmakerconf _always_ adds gnome2wmaker to its dependency list. This is a non-trivial addition as gnome2wmaker's Makefile uses the old 'USE_GNOME=yes' syntax which sucks in all of gnomeprefix, gnomehack and gtkhtml. gtkhtml pretty much takes care of sucking the rest of gnome in by declaring 'USE_GNOME=gnomehack gnomeprefix gnomehier glibwww libghttp libcapplet gal'. In this way we end up with 68 dependencies for a simple little program like wmakerconf. I would like to submit some PRs w/ patches to clean all of this up (or have a committer reading this just go and fix it without hassling around with gnats). Both x11-wm/wmakerconf and x11-wm/gnome2wmaker need to be fixed. gnome2wmaker needs to comply with the new bsd.gnome.mk policy regarding USE_GNOME, i.e. no more 'USE_GNOME=yes'. It should do this by setting USE_GNOME to whichever gnome component provides "menus". gnome2wmaker's purpose is to insert the gnome menu into the windowmaker menu, so it should require the part of gnome that provides menus. It is not immediately clear to me which component that might be. Perhaps one of the freebsd-gnome boys can shed some light on that. wmakerconf needs to be updated so that instead of testing to see if HAVE_GNOME is defined, it checks HAVE_GNOME for the same "menu" component. If that component is installed, then it should add gnome2wmaker to its dependencies. Which of the gnome components contains the "menus" and should be tested against? Should I submit PRs+patches or is there some ports or gnome committer who would prefer to clean these up? They both should be simple to fix. Thanks, Brandon D. Valentine -- brandon@dvalentine.com http://www.geekpunk.net Pseudo-Random Googlism: solstice is a time of self reflection