From owner-svn-ports-head@freebsd.org  Fri May  4 13:23:25 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1209FFAD8EC;
 Fri,  4 May 2018 13:23:25 +0000 (UTC) (envelope-from lars@e.0x20.net)
Received: from mail.0x20.net (mail.0x20.net [46.251.251.56])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "0x20.net",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A3C6D79A69;
 Fri,  4 May 2018 13:23:24 +0000 (UTC) (envelope-from lars@e.0x20.net)
Received: from e.0x20.net (mail.0x20.net [46.251.251.56])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.0x20.net (Postfix) with ESMTPS id 608BE48C54;
 Fri,  4 May 2018 15:23:22 +0200 (CEST)
Received: (from lars@localhost)
 by e.0x20.net (8.15.2/8.15.2/Submit) id w44DNMYw025033;
 Fri, 4 May 2018 15:23:22 +0200 (CEST) (envelope-from lars)
Date: Fri, 4 May 2018 15:23:22 +0200
From: Lars Engels <lars.engels@0x20.net>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r469014 - in head/net-mgmt/aircrack-ng: . files
Message-ID: <20180504132322.GB83184@e.0x20.net>
References: <201805041043.w44AhM8b028197@repo.freebsd.org>
 <20180504105124.GA23531@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180504105124.GA23531@FreeBSD.org>
X-Editor: VIM - Vi IMproved 8.0
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2018 13:23:25 -0000

On Fri, May 04, 2018 at 10:51:24AM +0000, Alexey Dokuchaev wrote:
> On Fri, May 04, 2018 at 10:43:22AM +0000, Lars Engels wrote:
> > New Revision: 469014
> > URL: https://svnweb.freebsd.org/changeset/ports/469014
> > 
> > Log:
> >   net-mgmt/aircrack-ng:
> >   
> >   Update to 1.2
> 
> Looks like too many changes for a rc->release bump.  Care to elaborate
> a bit Lars?

aircrack-ng has a slightly "special" release philosophy. RC 1 was
released on 2014-10-31, followed by RC 2 to 5 in the following years.
1.2 was then released three weeks ago.
> 
> > Modified: head/net-mgmt/aircrack-ng/Makefile
> >  
> > -USES=		cpe dos2unix gmake ssl
> > +USES=		autoreconf cpe dos2unix gmake libtool ssl
> 
> Why `autoreconf' is needed now?  That's a bit unfortunate...

Because upstream switched the build system to autotools with RC 4.
> 
> > +USE_GCC=	7.0+
> 
> This change is both surprising and unexplained in the commit log.

You're correct on this, sorry. INSTALLING states:

"* For best performance on FreeBSD (50-70% more), install gcc5 (or better) via: pkg install gcc7"

I should have mentioned this in the commit message.