From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 14 20:10:00 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 900E2484
for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
Wed, 14 May 2014 20:10:00 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
[IPv6:2001:1900:2254:206c::16:87])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client did not present a certificate)
by mx1.freebsd.org (Postfix) with ESMTPS id 6A6AA252F
for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
Wed, 14 May 2014 20:10:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4EKA0HB008653
for <freebsd-ports-bugs@freefall.freebsd.org>; Wed, 14 May 2014 20:10:00 GMT
(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4EKA0gH008652;
Wed, 14 May 2014 20:10:00 GMT (envelope-from gnats)
Resent-Date: Wed, 14 May 2014 20:10:00 GMT
Resent-Message-Id: <201405142010.s4EKA0gH008652@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
Ryan Steinmetz <zi@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 3DBA7318
for <freebsd-gnats-submit@FreeBSD.org>; Wed, 14 May 2014 20:01:39 +0000 (UTC)
Received: from cgiserv.freebsd.org (cgiserv.freebsd.org
[IPv6:2001:1900:2254:206a::50:4])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client did not present a certificate)
by mx1.freebsd.org (Postfix) with ESMTPS id 2B3F724E4
for <freebsd-gnats-submit@FreeBSD.org>; Wed, 14 May 2014 20:01:39 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s4EK1dbg091037
for <freebsd-gnats-submit@FreeBSD.org>; Wed, 14 May 2014 20:01:39 GMT
(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s4EK1dBw091030;
Wed, 14 May 2014 20:01:39 GMT (envelope-from nobody)
Message-Id: <201405142001.s4EK1dBw091030@cgiserv.freebsd.org>
Date: Wed, 14 May 2014 20:01:39 GMT
From: Ryan Steinmetz <zi@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: ports/189818: [patch] Do not make unbound's startup conditional on
unbound-anchors return code
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>,
<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 20:10:00 -0000
>Number: 189818
>Category: ports
>Synopsis: [patch] Do not make unbound's startup conditional on unbound-anchors return code
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Wed May 14 20:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Ryan Steinmetz
>Release:
>Organization:
>Environment:
>Description:
Today, unbound-anchor's return code will dictate whether or not unbound is able to start.
The attached patch causes unbound to try to start, even if unbound-anchor's return code is non-zero.
Since unbound-anchor has built-in validation content, unbound's successful startup should not be dependent on unbound-anchor's ability to pull a key from the Internet.
The patch also fixes a trailing whitespace issue.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 354086)
+++ Makefile (working copy)
@@ -3,7 +3,7 @@
PORTNAME= unbound
PORTVERSION= 1.4.22
-PORTREVISION= 2
+PORTREVISION= 3
CATEGORIES= dns
MASTER_SITES= http://unbound.net/downloads/
Index: files/unbound.in
===================================================================
--- files/unbound.in (revision 354086)
+++ files/unbound.in (working copy)
@@ -23,7 +23,7 @@
command="%%PREFIX%%/sbin/unbound"
extra_commands="reload"
start_precmd="start_precmd"
-reload_precmd="%%PREFIX%%/sbin/unbound-checkconf >/dev/null"
+reload_precmd="%%PREFIX%%/sbin/unbound-checkconf >/dev/null"
load_rc_config $name
@@ -41,6 +41,7 @@
su -m unbound -c "%%PREFIX%%/sbin/unbound-anchor ${unbound_anchorflags}"; \
fi &&
echo .
+ return 0
}
run_rc_command "$1"
>Release-Note:
>Audit-Trail:
>Unformatted: