From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 5 21:40:19 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12B7716A535 for ; Sun, 5 Dec 2004 21:40:19 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE30B43D5A for ; Sun, 5 Dec 2004 21:40:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iB5LeIeX005654 for ; Sun, 5 Dec 2004 21:40:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iB5LeIEG005653; Sun, 5 Dec 2004 21:40:18 GMT (envelope-from gnats) Resent-Date: Sun, 5 Dec 2004 21:40:18 GMT Resent-Message-Id: <200412052140.iB5LeIEG005653@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "knut st. osmundsen" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 282E616A4DC for ; Sun, 5 Dec 2004 21:36:15 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1904B43D1D for ; Sun, 5 Dec 2004 21:36:15 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iB5LaEPb005543 for ; Sun, 5 Dec 2004 21:36:14 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id iB5LaE2P005542; Sun, 5 Dec 2004 21:36:14 GMT (envelope-from nobody) Message-Id: <200412052136.iB5LaE2P005542@www.freebsd.org> Date: Sun, 5 Dec 2004 21:36:14 GMT From: "knut st. osmundsen" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/74743: wctype.c declares static array on stack X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Dec 2004 21:40:19 -0000 >Number: 74743 >Category: misc >Synopsis: wctype.c declares static array on stack >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 05 21:40:18 GMT 2004 >Closed-Date: >Last-Modified: >Originator: knut st. osmundsen >Release: 5.3 >Organization: >Environment: FreeBSD anduin.net 5.3-STABLE FreeBSD 5.3-STABLE #1: Thu Oct 21 23:08:04 CEST 2004 root@anduin.net:/usr/obj/usr/src/sys/ANDUIN amd64 >Description: The prop array in int wctype() implementation is instanciated on the stack every call. Sorry if this should be posted elsewhere, but this is my first time on sending a patch. I just happen to come across the code when I shopping code for a OS/2 libc. >How-To-Repeat: Call wctype(). >Fix: Index: wctype.c =================================================================== RCS file: /home/ncvs/src/lib/libc/locale/wctype.c,v retrieving revision 1.3 diff -u -5 -r1.3 wctype.c --- wctype.c 27 Mar 2004 08:59:21 -0000 1.3 +++ wctype.c 5 Dec 2004 21:27:26 -0000 @@ -40,11 +40,11 @@ } wctype_t wctype(const char *property) { - struct { + static const struct { const char *name; wctype_t mask; } props[] = { { "alnum", _CTYPE_A|_CTYPE_D }, { "alpha", _CTYPE_A }, >Release-Note: >Audit-Trail: >Unformatted: