Date: Wed, 05 Apr 1995 23:38:52 -0700 From: "Justin T. Gibbs" <gibbs@estienne.cs.berkeley.edu> To: "Jordan K. Hubbard" <jkh@freefall.cdrom.com> Cc: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>, jkh@freebsd.org (Jordan K. Hubbard), CVS-commiters@time.cdrom.com, cvs-ports@time.cdrom.com, vode@snakemail.hut.fi Subject: Re: cvs commit: ports/net/sup/patches patch-ae Message-ID: <199504060638.XAA21740@estienne.cs.berkeley.edu> In-Reply-To: Your message of "Wed, 05 Apr 1995 23:19:13 PDT." <11471.797149153@freefall.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> No man page updates for it :-(. >> No way to turn it off :-(. >> >> And admitted hackery in the code: >> + char rfname[1024]; /* Kludge alert.. */ > > >1. Sorry, I thought he'd changed the manpage. I'll document it if he > doesn't beat me to it. > >2. You turn it off by not creating a file with the special name.. :-) It doubles the number of stats needed to do an upgrade. It needs to be implemented another way and an option. I should be able to create #sup files all I want if I choose to distribute them via SUP. > >3. You would prefer that he simply not admit to the hackery? ;-) No, he should have used PATH_MAX or SUP's own STRINGLENGTH there I would guess. This patch, to a program that is crucial to so many developers, was adopted too quickly. The author even admitted to only a nights worth of testing. > > Jordan -- Justin T. Gibbs ============================================== TCS Instructional Group - Programmer/Analyst 1 Cory | Po | Danube | Volga | Parker | Torus ==============================================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199504060638.XAA21740>