From owner-p4-projects@FreeBSD.ORG Mon Dec 24 22:54:34 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5058316A41B; Mon, 24 Dec 2007 22:54:34 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0737916A417 for ; Mon, 24 Dec 2007 22:54:34 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E74F013C46B for ; Mon, 24 Dec 2007 22:54:33 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBOMsXWf042350 for ; Mon, 24 Dec 2007 22:54:33 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBOMsXO9042347 for perforce@freebsd.org; Mon, 24 Dec 2007 22:54:33 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Mon, 24 Dec 2007 22:54:33 GMT Message-Id: <200712242254.lBOMsXO9042347@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 131556 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2007 22:54:34 -0000 http://perforce.freebsd.org/chv.cgi?CH=131556 Change 131556 by rwatson@rwatson_cinnamon on 2007/12/24 22:53:47 Remove memory barrier/atomic XXX's, since that is now addressed. Affected files ... .. //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#26 edit Differences ... ==== //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#26 (text+ko) ==== @@ -339,11 +339,6 @@ * Notification from the BPF framework that a buffer has moved into the held * slot on a descriptor. Zero-copy BPF will update the shared page to let * the user process know. - * - * XXXRW: Do we need to use a memory barrier, atomic operation, or the like - * to make sure that the generation update is the last write to make it out - * after any packet date so that user space sees the generation increase only - * at or after the last packet data change? */ void bpf_zerocopy_bufheld(struct bpf_d *d) @@ -364,8 +359,6 @@ * held position can be moved to the free position, which can be indicated by * the user process making their generation number equal to the kernel * generation number. - * - * XXXRW: Memory ordering also an issue here? */ int bpf_zerocopy_canfreebuf(struct bpf_d *d)