From owner-cvs-all@FreeBSD.ORG  Sun Apr  1 14:57:29 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C47FE16A402;
	Sun,  1 Apr 2007 14:57:29 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 9582913C448;
	Sun,  1 Apr 2007 14:57:29 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 299464714E;
	Sun,  1 Apr 2007 10:57:29 -0400 (EDT)
Date: Sun, 1 Apr 2007 10:57:28 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Julian Elischer <julian@FreeBSD.org>
In-Reply-To: <200703290211.l2T2BlHv081735@repoman.freebsd.org>
Message-ID: <20070401104935.C75869@fledge.watson.org>
References: <200703290211.l2T2BlHv081735@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_file.c linux_util.h 
 src/sys/i386/linux linux.h linux_dummy.c linux_proto.h        
 linux_syscall.h linux_sysent.c syscalls.master src/sys/amd64/linux32
 linux.h linux32_dummy.c linux32_proto.h ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Apr 2007 14:57:29 -0000


On Thu, 29 Mar 2007, Julian Elischer wrote:

> julian      2007-03-29 02:11:46 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/compat/linux     linux_file.c linux_util.h
>    sys/i386/linux       linux.h linux_dummy.c linux_proto.h
>                         linux_syscall.h linux_sysent.c
>                         syscalls.master
>    sys/amd64/linux32    linux.h linux32_dummy.c linux32_proto.h
>                         linux32_syscall.h linux32_sysent.c
>                         syscalls.master
>  Log:
>  Implement the openat() linux syscall
>  Submitted by:   Roman Divacky (rdivacky@)
>  MFC after:      2 weeks

The locking and reference counting in this patch is highly dubious; also, 
vn_fullpath() should really not be used this way, as it fails whenever vnodes 
fall out of the name cache or a file system doesn't use the namecache (i.e., 
it is purely advisory).  If we're going to do openat() in the Linux emulation 
layer, let's instead implement it properly in the FreeBSD system call code as 
a first class service and then wrap it the way we wrap other system calls. 
Please do not MFC this patch as-is.

Robert N M Watson
Computer Laboratory
University of Cambridge