From owner-svn-src-all@freebsd.org Mon May 2 15:32:20 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BA62B2AAB4; Mon, 2 May 2016 15:32:20 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1DAF1742; Mon, 2 May 2016 15:32:19 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f66.google.com with SMTP id f63so27646116oig.0; Mon, 02 May 2016 08:32:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=9Vys6ep6K/OQTTU/y+K5MPO2nvzeny2PV9gpL8B5h4Y=; b=deHiS7l5zEBx/CoxZWsUB7ezjO9ngIzYg3mUiJGh8GWcHA3I+/3qEGyl9PxS0sXzfV fn59e6lXo/BTi7J8BlfEXKxtGl3K6hs4V4eS7Q9z6lnyF5rzMmFd8r5sZhCF3VDVmz5D nQNJPLQWujFhh9zaSsDWGa9mpcr2OXEVqZwNHeQlF9BnK5zSY0lnp22I83ZaMcngev8g 2RSeo0x4DntotsaaFEGySmYgs1ckiQOfWbxIIaWUhK1WrWd+rHfWZ9mLwaK7S3ILJV99 4/ryOx6+fdUmxj3eQ42kp04z//6iRHMmFc5xkCodv8tT7xvxLrpArYokdWQ+HIhzhq66 P2/Q== X-Gm-Message-State: AOPr4FUevKRPmczpqWVbwwRdAy3gvkeXOYA8v22Ldap9P4ZGEDt7MjZyR5AluaRl6ch2PA== X-Received: by 10.202.73.138 with SMTP id w132mr15052400oia.20.1462203132984; Mon, 02 May 2016 08:32:12 -0700 (PDT) Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com. [209.85.214.169]) by smtp.gmail.com with ESMTPSA id cf3sm10730203obc.1.2016.05.02.08.32.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 May 2016 08:32:12 -0700 (PDT) Received: by mail-ob0-f169.google.com with SMTP id j9so89714189obd.3; Mon, 02 May 2016 08:32:12 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.28.168 with SMTP id c8mr16185854obh.49.1462203132440; Mon, 02 May 2016 08:32:12 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.6.111 with HTTP; Mon, 2 May 2016 08:32:12 -0700 (PDT) In-Reply-To: <201605021507.u42F7hI3029685@repo.freebsd.org> References: <201605021507.u42F7hI3029685@repo.freebsd.org> Date: Mon, 2 May 2016 08:32:12 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r298924 - head/usr.bin/sdiff From: Conrad Meyer To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2016 15:32:20 -0000 Clang should really catch this too. Why didn't it? Best, Conrad On Mon, May 2, 2016 at 8:07 AM, Bjoern A. Zeeb wrote: > Author: bz > Date: Mon May 2 15:07:43 2016 > New Revision: 298924 > URL: https://svnweb.freebsd.org/changeset/base/298924 > > Log: > fgetc returns an int not a char. > > Found by: powerpc builds failing due to comparing with EOF raised: > "comparison is always false due to limited range of data type" > > Modified: > head/usr.bin/sdiff/sdiff.c > > Modified: head/usr.bin/sdiff/sdiff.c > ============================================================================== > --- head/usr.bin/sdiff/sdiff.c Mon May 2 14:35:57 2016 (r298923) > +++ head/usr.bin/sdiff/sdiff.c Mon May 2 15:07:43 2016 (r298924) > @@ -508,8 +508,7 @@ binexec(char *diffprog, char *f1, char * > static int > istextfile(FILE *f) > { > - int i; > - char ch; > + int ch, i; > > if (f == NULL) > return (1); >