From owner-freebsd-hackers@FreeBSD.ORG Sun Apr 27 12:54:53 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E565106567A for ; Sun, 27 Apr 2008 12:54:53 +0000 (UTC) (envelope-from gleb.kurtsou@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175]) by mx1.freebsd.org (Postfix) with ESMTP id B02788FC1C for ; Sun, 27 Apr 2008 12:54:52 +0000 (UTC) (envelope-from gleb.kurtsou@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so524258uge.37 for ; Sun, 27 Apr 2008 05:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject:message-id:mail-followup-to:mime-version:content-type:content-disposition:user-agent; bh=QIE38ZuzFt/i25MWXfclbjeNIcFYHQnYCRTqO1r4qFM=; b=vshF1uGsq42HoE6/89f7y4Z8lIkcl8K7w4KYpNGyBHONssDPtHoX7q0rfgJevpdO06GV9LwLn5z2N49ljQCM01WuGoMTWQT/B1zTH//cC4dlFYqLeXdiDAi3BdAQJCzSRms1w3IsROH7Tr4pntbtny6fZSNQtjP25nrrDhPuBzk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mail-followup-to:mime-version:content-type:content-disposition:user-agent; b=wuFOKI1pJGAZTWL2vZ+I6B77+E4JU+yqf5UyZ74bBP+A4LtkIxP7jqys8ilwE11OtfplpCUpgjRdnT0r41yzNPrXI0zDaSc3QwsjyV5mSdzQXpAAU3w/UIUzyOXSx0nMzHOV+xYKTO9+Pp78CvudKDQ286lNYY+knQ9mc683Op8= Received: by 10.66.216.7 with SMTP id o7mr3277097ugg.39.1209299446818; Sun, 27 Apr 2008 05:30:46 -0700 (PDT) Received: from localhost ( [213.184.224.26]) by mx.google.com with ESMTPS id f13sm5957211gvd.11.2008.04.27.05.30.44 (version=SSLv3 cipher=OTHER); Sun, 27 Apr 2008 05:30:45 -0700 (PDT) Date: Sun, 27 Apr 2008 15:36:14 +0300 From: Gleb Kurtsou To: hackers@freebsd.org Message-ID: <20080427123614.GA1138@h1.d> Mail-Followup-To: hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Subject: [patch] savecore can't create dump from encrypted swap X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2008 12:54:53 -0000 Issue was mentioned recently on stable@ http://docs.freebsd.org/cgi/mid.cgi?47F548D9.8060905 The problem is in order of rc.d scripts. After encswap finishes it's impossible to open original (not encrypted) swap device for write so savecore fails. The following patch adds 'encswap' target to be run after 'disks' but before 'swap1'. With the patch order of scripts becomes: dumpon geli savecore encswap swap1 instead of: dumpon geli encswap swap1 savecore The problem is that savecore looses ability to use syslog. You still get messages on console. The only solution I see is to use some hackery magic to inject log messages into kern.msgbuf with the help of /dev/console. I'm not sure it's really needed. diff -ur rc.d.orig/encswap rc.d/encswap --- rc.d.orig/encswap 2008-04-27 14:53:38.000000000 +0300 +++ etc/rc.d/encswap 2008-04-27 14:53:27.000000000 +0300 @@ -4,7 +4,7 @@ # -# PROVIDE: disks -# REQUIRE: initrandom +# PROVIDE: encswap +# REQUIRE: initrandom disks # KEYWORD: nojail . /etc/rc.subr diff -ur rc.d.orig/savecore rc.d/savecore --- rc.d.orig/savecore 2008-04-27 14:53:38.000000000 +0300 +++ etc/rc.d/savecore 2008-04-27 14:53:27.000000000 +0300 @@ -4,8 +4,7 @@ # # PROVIDE: savecore -# REQUIRE: syslogd -# BEFORE: SERVERS +# BEFORE: encswap # KEYWORD: nojail . /etc/rc.subr diff -ur rc.d.orig/swap1 rc.d/swap1 --- rc.d.orig/swap1 2008-04-27 14:53:38.000000000 +0300 +++ etc/rc.d/swap1 2008-04-27 14:53:27.000000000 +0300 @@ -4,7 +4,7 @@ # # PROVIDE: localswap -# REQUIRE: disks +# REQUIRE: encswap disks # KEYWORD: nojail shutdown . /etc/rc.subr