From owner-freebsd-arch Sat Jan 20 13:32:17 2001 Delivered-To: freebsd-arch@freebsd.org Received: from gw.nectar.com (gw.nectar.com [208.42.49.153]) by hub.freebsd.org (Postfix) with ESMTP id CB42437B402 for ; Sat, 20 Jan 2001 13:31:59 -0800 (PST) Received: from hamlet.nectar.com (hamlet.nectar.com [10.0.1.102]) by gw.nectar.com (Postfix) with ESMTP id 97266193EE; Sat, 20 Jan 2001 15:31:58 -0600 (CST) Received: (from nectar@localhost) by hamlet.nectar.com (8.11.1/8.9.3) id f0KLVwc88206; Sat, 20 Jan 2001 15:31:58 -0600 (CST) (envelope-from nectar@spawn.nectar.com) Date: Sat, 20 Jan 2001 15:31:58 -0600 From: "Jacques A. Vidrine" To: Daniel Eischen Cc: arch@freebsd.org Subject: Re: Request For Review: libc/libc_r changes to allow -lc_r Message-ID: <20010120153158.A88123@hamlet.nectar.com> References: <3A68DDE8.7F8D3C51@vigrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3A68DDE8.7F8D3C51@vigrid.com>; from eischen@vigrid.com on Fri, Jan 19, 2001 at 07:38:00PM -0500 X-Url: http://www.nectar.com/ Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Jan 19, 2001 at 07:38:00PM -0500, Daniel Eischen wrote: [snip] > Overview of the changes > ----------------------- Thanks for the hard work and the great overview! I have one objection: [snip] > _thread_sys_foo - actual syscall > _foo - weak definition to _thread_sys_foo > foo - weak definition to _thread_sys_foo > > I've changed all the instances of foo() to _foo() in libc for > those hidden system calls. Anyone modifying or adding to libc > will have to be careful to use the same conventions. Please, no. Kill `un-namespace' and let us continue to use the correct name for `foo'. Adding underscores in front of lotsa common calls hurt my eyes and hinders porting between different libc implementations (e.g. our `old' one, other *BSDs). By the way, should it be __thread_sys_foo and __foo? Two underscores? ISTR some rule about using a single leading underscore for file scope (e.g. macros) and two for global scope. Finally, I hope this will lead us into introducing all non- Standard C (or at least non-POSIX) function identifiers in the same fashion, so as to clean up our namespace. For example, err(3). Thanks again & Cheers, -- Jacques Vidrine / n@nectar.com / jvidrine@verio.net / nectar@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message