From owner-cvs-src@FreeBSD.ORG  Tue May  4 10:45:14 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6E1B216A4D1; Tue,  4 May 2004 10:45:14 -0700 (PDT)
Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CA52843D3F; Tue,  4 May 2004 10:45:13 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i44HjB5v019470;	Wed, 5 May 2004 03:45:11 +1000
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i44Hj7HW031109;	Wed, 5 May 2004 03:45:09 +1000
Date: Wed, 5 May 2004 03:45:06 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Doug Barton <DougB@DougBarton.net>
In-Reply-To: <40976D24.4060408@DougBarton.net>
Message-ID: <20040505033532.C11102@gamplex.bde.org>
References: <200405040239.i442dfL0011742@repoman.freebsd.org>
 <40970329.3070507@freebsd.org> <40975C30.5D247B83@freebsd.org>
 <40976D24.4060408@DougBarton.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Scott Long <scottl@freebsd.org>
cc: src-committers@freebsd.org
cc: Andre Oppermann <andre@freebsd.org>
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/net if_vlan.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2004 17:45:14 -0000

On Tue, 4 May 2004, Doug Barton wrote:

> Andre Oppermann wrote:
>
> > However it worked for me just fine.  The reason I just found out is that
> > I wasn't compiling if_vlan into the kernel but loaded and tested it as
> > module.  Compiling it as module doesn't give any compiler warning and
> > works w/o a hitch.  Dunno why?
>
> Testing both should be standard operating procedure before you commit.
> Of course there _should_ be no difference, but that's why you do testing
> on stuff like this.

The difference is because there is too much in kern.pre.mk.  In
particular, the setting of -Werror.  Only kern.mk is common to building
kernels and modules.

Other misplaced things: -D_KERNEL -fno-common -finline_limit=${INLINE_LIMIT}.
These are just duplicated, complete with icc ifdefs for the last 2.

Bruce