Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Sep 2011 03:07:52 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r225821 - head/sys/dev/ath
Message-ID:  <201109280307.p8S37qKB052603@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Wed Sep 28 03:07:51 2011
New Revision: 225821
URL: http://svn.freebsd.org/changeset/base/225821

Log:
  Fix lock order to be correcter.
  
  Nothing else locks these two queues (cabq, avp mcastq), but it should
  be consistent and correct.

Modified:
  head/sys/dev/ath/if_ath.c

Modified: head/sys/dev/ath/if_ath.c
==============================================================================
--- head/sys/dev/ath/if_ath.c	Wed Sep 28 03:05:04 2011	(r225820)
+++ head/sys/dev/ath/if_ath.c	Wed Sep 28 03:07:51 2011	(r225821)
@@ -2620,8 +2620,8 @@ ath_beacon_generate(struct ath_softc *sc
 		}
 		/* NB: gated by beacon so safe to start here */
 		ath_hal_txstart(ah, cabq->axq_qnum);
-		ATH_TXQ_UNLOCK(cabq);
 		ATH_TXQ_UNLOCK(&avp->av_mcastq);
+		ATH_TXQ_UNLOCK(cabq);
 	}
 	return bf;
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109280307.p8S37qKB052603>