From nobody Mon May 16 20:18:50 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E0ACC1AD5DC3 for ; Mon, 16 May 2022 20:18:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L29Z25Jmsz4yxV for ; Mon, 16 May 2022 20:18:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 93CB326B30 for ; Mon, 16 May 2022 20:18:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24GKIoB7049146 for ; Mon, 16 May 2022 20:18:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24GKIoVM049145 for fs@FreeBSD.org; Mon, 16 May 2022 20:18:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 263811] ffs(4): Disk with garbage can cause crash in taste ffs crc32 code: panic: g_read_data(): invalid length -268744963 Date: Mon, 16 May 2022 20:18:50 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652732330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qv1JLvZ12g81SREvy7WCliTpv2gVZQGJ3LBhjTH8waM=; b=J/hilADkGvH0GKHebu5n6sg/heCbauwTROpIS8F3WTmhMojXabiexIMTIIBW6+WQFao8Ha xPa1Cux+EinVUzN8NKXFETk2VZyjsMVU+wsn/8pBrM3LvItxCm2vVO0ngZrMcM3H6bGRSK tuC9fgGgeY64dkkMvGZhmEDkCkAuuvcsClqqT00B4e325oUo8pn7TK4qao8n8qT6atETzK jRF7Y+dhdSa2qi1JrAxpcUGRNP0vRwHBVRodHcn66h7U1/JFbk6aCT0N4Z6N0+77mPy62O kfrTi4TCt6opBzTHlJ2N/bhaMaEWKCjlaxpBCebqe8Dhs5+sit7/Ym471YhWbA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652732330; a=rsa-sha256; cv=none; b=D5Lb6LNgObCOGHsoaWRiFZuB/p/3ZHhlC8vSQVoJLy0mAdDxHxZ+XYQ2dlKaORLXTLdHAr /pAJV5hOfWctr+rrYNLq+YBCV7jPG8WINNNwGjmuWsBWIbqyeODM4rTFVKOQeEFoi2muvp 1I2zw+BYxz2dPSjB8yHeLhvQwVxYH67vxejPHfQlSjigSAH5xD4qma4+xHhclW/HVTa/3D Exid2bcMvSO+XUvKxhPZ6MMcaApf8mPT93ms1V00z0HCXByngybbawLS4wwrhDQVaQNT8q 5PxAJKMqBiHkdDPRvEE7NsgSRGKCbwQYKiAPDNyT7Y83z7p08thMUl8s6JN1kA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263811 --- Comment #4 from Kirk McKusick --- (In reply to Robert Morris from comment #3) Right. The lower bound test should be fs->fs_sbsize < fs->fs_fsize since a zero-length superblock size would be wrong. I am working on some other feedback about problems that the checks cause. I will do an update to the patch when I have figured them out. Thanks for your help in identifying and fixing these vulnerabilities. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=