From owner-svn-src-head@freebsd.org Mon May 9 17:04:07 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5320EB343B5; Mon, 9 May 2016 17:04:07 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x242.google.com (mail-oi0-x242.google.com [IPv6:2607:f8b0:4003:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 17ACA134B; Mon, 9 May 2016 17:04:07 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi0-x242.google.com with SMTP id w198so27557867oiw.2; Mon, 09 May 2016 10:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=6lQN1Gs2rvNP1QJ69NsQEUvViUyQVxY92Hwc0YNENog=; b=gqZR8hBfjFDMHdcZC7nfGfByInace2gdCwzBRYIJ2822McSk/WlgWWdjC1xltJMYLh T4cqOuAUZGbNqQQHKlKR1obIj9CB3KexO6sQLhaLqHU3QbMOlXjmHk7hEetN3xTx2FBb DgAxCYck+7PNF9yIESUrlXR0vsbHrK5aXnGkvn7UDj4tG2uxtxKRqYlLsaj3rzcjDN4C /P91s60cfpTfdwFSW4R1O+9l9+CR2QTpJc9TGDtIM0PzyxkoeSguYhv6SyqdWu3IoYqy lBYaZLPAMbRt6bSQIt9jXBLYh5Pzb1HiJXxfMvWt3Anx8sFmoMF/Yvm7vw79pQSW+Zgt 7nLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=6lQN1Gs2rvNP1QJ69NsQEUvViUyQVxY92Hwc0YNENog=; b=PyGmabsidYhrV57gDgcsUTs9T+3sckrVTmRqjuC8iP3LiBmjABvnjnQbusCxjIRrHp Jvy/ifKTZ3D/syrBwqWB+9t9rahaWIGYKE7p/SLq3IypyQ+igp2VBrv32OfYoxAyLGx8 dQF6dbHCsgTuQZIWW9pHry9LH31VyYIOHO4IN63zax7gAzX44W4AKLGEWJjlwETVj3J1 nFZdttkDM4fJ1A0f8hyTWBVlgMYQUPrqfKD9XPm+WIqPWU6HnOY+TjTZJ980q9f8QNO3 SaW+E/HI8jyY3HzyLCYHF1H4Q5oelTkT/rFGCrtyU1pkZ/3YNKJ6hwxhN1aCUv0GS8ar 88iw== X-Gm-Message-State: AOPr4FVD5nS8yOoEp6HwHCkIwl6aCvACkTJk4pGfirKf0VD8SBU0IGZPrpjq5hNutJKc5gIqlM0gTrQ68kOTmQ== MIME-Version: 1.0 X-Received: by 10.157.46.70 with SMTP id c6mr688517otd.106.1462813446260; Mon, 09 May 2016 10:04:06 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.64.138 with HTTP; Mon, 9 May 2016 10:04:06 -0700 (PDT) In-Reply-To: <201602171716.u1HHG2c2098316@repo.freebsd.org> References: <201602171716.u1HHG2c2098316@repo.freebsd.org> Date: Mon, 9 May 2016 11:04:06 -0600 X-Google-Sender-Auth: pEVbTDupTGYOA6w1YXxyIYapknA Message-ID: Subject: Re: svn commit: r295707 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs dev/mmc dev/virtio/block geom geom/journal geom/mirror geom/raid geom/raid3 kern From: Alan Somers To: Warner Losh Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Steven Hartland Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 17:04:07 -0000 On Wed, Feb 17, 2016 at 10:16 AM, Warner Losh wrote: > Author: imp > Date: Wed Feb 17 17:16:02 2016 > New Revision: 295707 > URL: https://svnweb.freebsd.org/changeset/base/295707 > > Log: > Create an API to reset a struct bio (g_reset_bio). This is mandatory > for all struct bio you get back from g_{new,alloc}_bio. Temporary > bios that you create on the stack or elsewhere should use this before > first use of the bio, and between uses of the bio. At the moment, it > is nothing more than a wrapper around bzero, but that may change in > the future. The wrapper also removes one place where we encode the > size of struct bio in the KBI. > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > head/sys/dev/mmc/mmcsd.c > head/sys/dev/virtio/block/virtio_blk.c > head/sys/geom/geom.h > head/sys/geom/geom_io.c > head/sys/geom/journal/g_journal.c > head/sys/geom/mirror/g_mirror.c > head/sys/geom/raid/g_raid.c > head/sys/geom/raid3/g_raid3.c > head/sys/kern/kern_physio.c > smh noticed that while your commit message says that g_reset_bio is mandatory after g_{new,alloc}_bio, your diff only replaced existing calls to bzero. You didn't insert g_reset_bio calls after all g_alloc_bio calls, for example in vdev_geom_io_start. Do you intend to follow up this change with a g_reset_bio everywhere that g_alloc_bio is called, or did you mean that g_reset_bio is optional after all bios returned by g_{new,alloc}_bio?