From owner-freebsd-current@FreeBSD.ORG  Thu Oct 22 03:16:58 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 99CCF106566C
	for <freebsd-current@freebsd.org>; Thu, 22 Oct 2009 03:16:58 +0000 (UTC)
	(envelope-from bf1783@googlemail.com)
Received: from mail-ew0-f209.google.com (mail-ew0-f209.google.com
	[209.85.219.209])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B6518FC16
	for <freebsd-current@freebsd.org>; Thu, 22 Oct 2009 03:16:57 +0000 (UTC)
Received: by ewy5 with SMTP id 5so4062052ewy.36
	for <freebsd-current@freebsd.org>; Wed, 21 Oct 2009 20:16:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type;
	bh=DoQUqW6qThyn+Qo9ZKoYJf/x5YDvJG7g3DlCaRqQiFc=;
	b=DblvnT5YjBCofby0xCNDRWajS8qLUeb2P5ab5xtFKBg16no0tYr9lwnpk95EtIdgPL
	mQf/8wQzyfyE2p4Ag7GeY9GhS1+PuYjEfYoz+mbrFy8iiPnSflXHHHR0pjzusbGKbX6x
	E1c+xMl51VfmKooKd+7k4rPnLEUja5PsT7V58=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=pNqSvaEfkRWjiggZW1lJ1DXKK2UOAt9f2ot1WCUYaTRQQhs5Tzurqop8iU5v/IXvoz
	ou0Bjw/NYz7pft4ax1QZIcuQ0oXGsGyvuGb42wrIEOxkGk7N2b8Ae+PTBClNERj8z8uG
	Syg4ic2C0C6+DQO3WhKNwONgwmDskLvIc9u08=
MIME-Version: 1.0
Received: by 10.216.91.84 with SMTP id g62mr187432wef.216.1256181416967; Wed, 
	21 Oct 2009 20:16:56 -0700 (PDT)
In-Reply-To: <B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com>
References: <d873d5be0910201621h768e126dq34df38c07b83fe47@mail.gmail.com>
	<bc2d970910201734o332582ceic30fb7e42e14c812@mail.gmail.com>
	<d873d5be0910201900w67833e83kf53b556e2b5c8d00@mail.gmail.com>
	<bc2d970910202030u2c03571etb6379cf29260617d@mail.gmail.com>
	<9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com>
	<B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com>
Date: Thu, 22 Oct 2009 03:16:56 +0000
Message-ID: <d873d5be0910212016qea39846v45a3ddd21ee45d55@mail.gmail.com>
From: "b. f." <bf1783@googlemail.com>
To: "Li, Qing" <qing.li@bluecoat.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-current@freebsd.org
Subject: Re: svn commit: r198306 - head/sys/net
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Oct 2009 03:16:58 -0000

On 10/21/09, Li, Qing <qing.li@bluecoat.com> wrote:
> I reviewed the SMP code and architecture modules last night. After
> discussion
> with Kip Macy, we feel using the "#ifdef SMP" is actually not necessary
> here.
>

Perhaps not strictly necessary, but wouldn't it be better to have it?
What is your rationale for not using making it conditional on SMP?  I
note that these will be the only such unconditional uses of that
variable that I see in the tree, other than the definition in
sys/sys/smp.h.

Regards,
                 b.