From owner-freebsd-dtrace@FreeBSD.ORG  Fri Nov 14 15:41:20 2014
Return-Path: <owner-freebsd-dtrace@FreeBSD.ORG>
Delivered-To: freebsd-dtrace@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 256A114F
 for <freebsd-dtrace@FreeBSD.org>; Fri, 14 Nov 2014 15:41:20 +0000 (UTC)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 74A027D6
 for <freebsd-dtrace@FreeBSD.org>; Fri, 14 Nov 2014 15:41:19 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA16813;
 Fri, 14 Nov 2014 17:43:04 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1XpIzm-000MtD-FA; Fri, 14 Nov 2014 17:41:10 +0200
Message-ID: <5466225E.2050902@FreeBSD.org>
Date: Fri, 14 Nov 2014 17:40:14 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: George Neville-Neil <gnn@neville-neil.com>
Subject: Re: removing solaris cyclic
References: <543643A1.6030002@FreeBSD.org>
 <49A880FD-F346-4033-A1E5-BA1BB69FD2DA@neville-neil.com>
In-Reply-To: <49A880FD-F346-4033-A1E5-BA1BB69FD2DA@neville-neil.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-dtrace@FreeBSD.org
X-BeenThere: freebsd-dtrace@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "A discussion list for developers working on DTrace in FreeBSD."
 <freebsd-dtrace.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-dtrace>, 
 <mailto:freebsd-dtrace-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-dtrace/>
List-Post: <mailto:freebsd-dtrace@freebsd.org>
List-Help: <mailto:freebsd-dtrace-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace>,
 <mailto:freebsd-dtrace-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2014 15:41:20 -0000

On 09/10/2014 18:34, George Neville-Neil wrote:
> On 9 Oct 2014, at 4:13, Andriy Gapon wrote:
> 
>> I would like to ask for a review and/or testing of the following branch
>> for a phased removal of solaris cyclic code: 
>> https://github.com/avg-I/freebsd/compare/review/no-cyclic Raw diff:
>> https://github.com/avg-I/freebsd/compare/master...review/no-cyclic.diff
>> 
>> The only user of cyclic now is DTrace profile provider, so I am
>> converting it to use our improved callout(9).  cyclic is almost a
>> complete implementation of an alternative to our callout(9), so having
>> that big chunk of foreign code which duplicates a core function is not
>> nice.
>> 
>> One thing that I am not sure about is what PROF_ARTIFICIAL_FRAMES should
>> be on different platforms.  Also, I am not sure if the number of
>> interrupt, timer, etc frames depends on a timer being used.  I'd
>> appreciate any help on this.
> 
> Can you create a reviews.freebsd.org patch for this?

Done: https://reviews.freebsd.org/D1161

-- 
Andriy Gapon