From owner-freebsd-ports@FreeBSD.ORG Wed Jul 23 10:38:57 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11350106566C for ; Wed, 23 Jul 2008 10:38:57 +0000 (UTC) (envelope-from florent.thoumie@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.231]) by mx1.freebsd.org (Postfix) with ESMTP id E697E8FC0A for ; Wed, 23 Jul 2008 10:38:56 +0000 (UTC) (envelope-from florent.thoumie@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so2786328rvf.43 for ; Wed, 23 Jul 2008 03:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=mKYXaoiD7pK/3SUb55+D0KQ/CHFZk/xtCs/uDNspxec=; b=g7CcJQiHGHGeKUL6G3qW1DQBDGN743xODtRLsmGgA6N0jafqUYlB6Pn+xz832MhG78 gd8VV9RX5I0gbAvrO6RETloohR1jP5/UKo6qfww+G9+jCCSEcJ8SspKB1SNTF9C0HiM7 y5cbDgguULEbKl+KJdWiTmwBUHh+UYqVTY0bk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=S39uOfZcgqNtIxN12v5Rc0g02C1xeHYMJyrGflVUxPtbs/4KD/C5EPBtXKuG3ihhq1 5C6xcszb3OE37xSKMdpK6DfErGr+4G2H64q4P8W5+mubdL2qNd6Ha95p2JGJUlj1Wjfs O9yJaPyhNxFnNnxi1dI2WhiHuqFIKns0scMHI= Received: by 10.115.19.16 with SMTP id w16mr4705765wai.102.1216808041894; Wed, 23 Jul 2008 03:14:01 -0700 (PDT) Received: by 10.114.60.15 with HTTP; Wed, 23 Jul 2008 03:14:01 -0700 (PDT) Message-ID: Date: Wed, 23 Jul 2008 11:14:01 +0100 From: "Florent Thoumie" Sender: florent.thoumie@gmail.com To: osvaldsson@icelandic.net In-Reply-To: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> X-Google-Sender-Auth: 2d7c0c08ef9fbd0e Cc: ports@freebsd.org, pgollucci@freebsd.org, araujo@freebsd.org Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 10:38:57 -0000 On Tue, Jul 22, 2008 at 11:41 PM, Olafur Osvaldsson wrote: > Why has committing a patch gotten so complicated? One day since the last update to the PR... The PR responsible recently got repository privileges so he's probably getting familiar to the procedures. While I'm looking at it, you're checking if NO_INSTALL_MANPAGES which is wrong. This variable is meant to be set by ports, not users. Even if it were, you would end up with a incomplete packing list, because your port installs manual pages unconditionally. I'd suggest getting rid of the check completely. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer