From nobody Fri Jun 26 15:24:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gmzwn5Fllz6jftt for ; Fri, 26 Jun 2026 15:24:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gmzwn3tMCz3syr for ; Fri, 26 Jun 2026 15:24:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782487449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XErJic6XwSJl+N+lkPXO/Frx4yk4DKT+/153i4KkoPs=; b=YLo2wMRdYsKS042//QlGgv1lEyWTB04R9i8BqOLcEDRirU51y2+CycMgNm7KI2t7RWmcL9 Cd2Dxk0GObwXZ1JfYzZn4T7BbQ9PoGLyMH+Ou2Mq00iEgPa205P8g7ph51hYQWDYmBbbVl QSTXWS49GCW5sbiqDbT3wQuAVEhtHTBpTSp65NrV27maZq73EUmFRe/7C9FG3XRTAp4R2H xkeeu/QTZyvy5+dL2kjevNBERTGh6ATcXUMA6II7sFnrF5/OxnGvpxL+zJH1NtwTfrDu/h JR8gc9mxAg1FnZ9oG/RjA6N4pi683zFbEpC1zgVHn/RRH8E87JKSxt0A6jqJ8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782487449; a=rsa-sha256; cv=none; b=b9Puo5ybOpUbb1EyfxvjMZETzsCENCG+H+XE8yuQV5UTaQWtNXRDqvCR6FB2AzLk9P/PfW J826m1vdGsfZudLgsrY1RS8/eAld7necweeylEM04BW4+Bjkf2YtmfHxnS01j0I7klfW2t SY8Iq7HcKeWKMIsQy6eSYl0+ayUeKpqZIarDVbQTbWuHs9u0+xSER/2cFDo9gp/MkadfXO rzeyzHf8PSzHhCEyjhz0LeYhq7NX2P1D+eTzO3oJ+e+MTsqNL/a++Psnfk1OfrBqxIk5bi xKhx+Tti9qnvWba4vseycrsYKSD8uwg1eHJML0irG2cRAyYEfDRv8nzJlSXMWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782487449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XErJic6XwSJl+N+lkPXO/Frx4yk4DKT+/153i4KkoPs=; b=bzmI3Pi0R6Dc94W63GLSvWI+4sBAigjnMmzGJYNyZ3OKCYiym1u5xT7UN95JI/smkNKE1Q Q2+YB+bzOov+8cdxVuYvMfsFtHFpnSo8TcGSjBwtqwGA+cLoous6XjjMYW1vquQZtybknj eE3D7tcRezTaqUWf+EjIEMGVWybMRr7pX3yYPFX0UmTzI8wv8tvGzNT9kdqgieliJlEOUC /g8Vvz8ZG7IGfThpGt4pp0pn+p69rShGIrfdHwTixYCB1WHceJMQnD7aW+PGwZQikYLGem v6/1cegsjhzF5D8l7ZToFcDOgdq5HlzyRuoGgaKz6IGmT2qOz9BobiptxviBGw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gmzwn2h0fzk4g for ; Fri, 26 Jun 2026 15:24:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24143 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Jun 2026 15:24:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: ad26a56cf2f5 - main - acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad26a56cf2f55967cc73d04a6ea17c27892d3141 Auto-Submitted: auto-generated Date: Fri, 26 Jun 2026 15:24:09 +0000 Message-Id: <6a3e9999.24143.f30b7b0@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=ad26a56cf2f55967cc73d04a6ea17c27892d3141 commit ad26a56cf2f55967cc73d04a6ea17c27892d3141 Author: Olivier Certner AuthorDate: 2026-06-26 15:21:41 +0000 Commit: Olivier Certner CommitDate: 2026-06-26 15:23:43 +0000 acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean Same reason as for the previous commit to acpi_cpu(4). This boolean is not used anywhere. Disabling acpi_timer(4) can be done through the regular ACPI disable mechanism (using the 'debug.acpi.disabled' tunable, see acpi_disabled()). Reviewed by: emaste (implicit) Fixes: ac3ede5371af ("x86/xen: remove PVHv1 code") MFC after: 3 days Event: Halifax Hackathon 202606 Location: Dalhousie CS Faculty building Sponsored by: The FreeBSD Foundation --- sys/dev/acpica/acpi_timer.c | 6 +----- sys/x86/include/init.h | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/sys/dev/acpica/acpi_timer.c b/sys/dev/acpica/acpi_timer.c index 84d9fb8e6ac8..08bfa292bf90 100644 --- a/sys/dev/acpica/acpi_timer.c +++ b/sys/dev/acpica/acpi_timer.c @@ -64,9 +64,6 @@ static eventhandler_tag acpi_timer_eh; static u_int acpi_timer_frequency = 14318182 / 4; -/* Knob to disable acpi_timer device */ -bool acpi_timer_disabled = false; - static void acpi_timer_identify(driver_t *driver, device_t parent); static int acpi_timer_probe(device_t dev); static int acpi_timer_attach(device_t dev); @@ -125,8 +122,7 @@ acpi_timer_identify(driver_t *driver, device_t parent) ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); if (acpi_disabled("timer") || (acpi_quirks & ACPI_Q_TIMER) || - acpi_timer_dev || acpi_timer_disabled || - AcpiGbl_FADT.PmTimerLength == 0) + acpi_timer_dev || AcpiGbl_FADT.PmTimerLength == 0) return_VOID; if ((dev = BUS_ADD_CHILD(parent, 2, "acpi_timer", 0)) == NULL) { diff --git a/sys/x86/include/init.h b/sys/x86/include/init.h index 42b194de26b9..200a90d31b5e 100644 --- a/sys/x86/include/init.h +++ b/sys/x86/include/init.h @@ -43,7 +43,4 @@ struct init_ops { extern struct init_ops init_ops; -/* Knob to disable acpi_timer device */ -extern bool acpi_timer_disabled; - #endif /* __X86_INIT_H__ */