From owner-freebsd-ports@freebsd.org Thu Oct 26 12:22:53 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0A5AE4856C; Thu, 26 Oct 2017 12:22:53 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7ABE07C5C7; Thu, 26 Oct 2017 12:22:53 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x22a.google.com with SMTP id a192so2539860pge.9; Thu, 26 Oct 2017 05:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2Jkkc2e598Lg535guTLTOH2mJVIWQ0fruYgyb/vgZdU=; b=p3mjUONz9DRvbFQ1Q8QUEf3sIB80P4PgUEd3K8RiB8YsHABU4FVRrADPwU4gaeZEid Kk3Qb/s5elJn9sXSG5tDinJ6LyeNJgO5xt9aT7IrD1xjQyeKbFg8ikDKQwwC8hoQHDhm Ojw8OIlxqPgIg4Ck6SXLKNgjv0jHjNBdyyRBWs8WW4CTjVFKlrSuzoQMXnhhMzaAicIi U0VmE7PmG9N/yHWrn6nOIZMh45JjalCB5Kuq62ossB5bln75J9+I8KaKGjR6EyJQIMdT JoHe1P01RPY+N7hqB1qcUxorhRk9JnGS/WqwZWBrAzuF1W5ie5CuD38fDMTfoVehHpAh aW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from:cc :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2Jkkc2e598Lg535guTLTOH2mJVIWQ0fruYgyb/vgZdU=; b=NC5q7gco0WhcuoT4Lq3vQFuzg65jTjqxkNPlumJTgP8IdnrFzekjHf0F5udFMBwDjy 08aeic99j2b6lRY0xb7Q84tdRT3D+gsamVYvo3xT/6c/kfFlJAWx30Q/wXGoMyK+9ojV N5RdITMzWr7pnw90uboQpD1w1BEj3Z/c98H1jAamXVVC06gNc2UV2fwfIcyDTwAnnkJT 5ebIqoPlc3V0gV2Rz8Zkhe1ko5ZCFXLokUty5I8dII4IVUJKp7WVfZDllXacUzKdB7Bb v6tNfPCVy86WwkCac9ggNZ3z7KsP/cuk8y3GukTo5TSPGRCqsX8PvFen6rBtUzIo4yE8 ftfw== X-Gm-Message-State: AMCzsaVgRWb3EzFwPxEBtr4pIaM6cCN0Ansv1i5o6SvGfvfROPRsyh4p yklCcdDM0RwtXbiRsB5wpvi98OFj X-Google-Smtp-Source: ABhQp+TL+K01yI7LGfB2I4B66i/ITLiEIfRMCrJI63vRncJkB2Tm0z2AlCfQaAIyZB4o6oFXcE7M2Q== X-Received: by 10.99.124.24 with SMTP id x24mr4815790pgc.90.1509020572603; Thu, 26 Oct 2017 05:22:52 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:9442:79f1:c7c:81a3? (2001-44b8-31ae-7b01-9442-79f1-0c7c-81a3.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:9442:79f1:c7c:81a3]) by smtp.gmail.com with ESMTPSA id 68sm10401006pfx.105.2017.10.26.05.22.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Oct 2017 05:22:52 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: Files conflicts in ports To: Rodrigo Osorio References: <4b8e99ea-a9d9-c065-13a6-d54142cb2556@tuxfamily.org> <649b431c-3eba-c1ed-fa70-68a6c19850db@FreeBSD.org> From: Kubilay Kocak Cc: freebsd-ports@freebsd.org, python Message-ID: <0c7dc023-cfbc-8942-d818-ff768ed5236f@FreeBSD.org> Date: Thu, 26 Oct 2017 23:15:51 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 12:22:53 -0000 On 10/26/17 11:00 PM, Rodrigo Osorio wrote: > > On 10/26/17 13:45, Kubilay Kocak wrote: >> On 10/26/17 3:58 PM, L.Bartoletti wrote: >>> Hi Rodrigo, >>> >>> Thank you for this precious tool. >>> >>> One question, seeing one of my ports which have conflicts >>> (devel/py-gtfslib >>> http://pkgtool.osorio.me/conflicts/lbartoletti@tuxfamily.org.html). Is >>> it or not good to install test files? >> >> They're all effectively upstream bugs: installing modules into shared >> locations. 'tests' is a common enough module name that its one of the >> most easily observed in practice. >> >> There's nothing intrinsically wrong with tests being installed, but they >> should be under/within their package module directories. >> >> Most projects exclude them (from installation) with something like: >> >> packages = find_packages(exclude=[...]), >> >> Though doing the above for a project with this packaging 'bug' is not >> really the correct solution. Maybe for a short term >> files/patch-setup.py, but report it upstream >> >>> Regards. >>> >>> Loïc >>> >>> On 10.10.2017 20:52, Rodrigo Osorio wrote: >>>> Dear port maintainers, >>>> >>>> It appears that a number of ports install files with the same names at >>>> the same locations, >>>> causing file conflicts and unexpected behaviors for users. >>>> >>>> To help solving this issue I ran a tool to list per maintainer the >>>> conflicting ports with >>>> the list of impacted files ; the list is updated every day at 4am UTC. >>>> >>>> http://pkgtool.osorio.me/conflicts/ >>>> >>>> I believe most of the conflicts are trivial and can be solved with a >>>> proper declaration in the CONFLICTS variable. >>>> So take a look at it and don't hesitate to come back to me if you have >>>> questions. >>>> >>>> best regards, >>>> >>>> - rodrigo >>>> > I agree with Kubilay, If tests aren't relevant for production use the > can be skipped. > The point here is many (if not all) py- packages install the same test > files and this is wrong. > > - rodrigo Just to be explicit, in describing them as upstream bugs, I didn't also mean they're *not* port bugs. The above ports, and any port in fact, that currently install conflicting files, must either: - Add CONFLICTS[_*] with all of their conflicting ports, OR - Not install them This is separate from the issue of value-of-installed-python-tests-for-*package*-users (*ports* users can run them via the sdist in WRKSRC), and separate from the method of resolving the conflict (removal, rename, upstream bug fix, patch, etc) ./koobs