From owner-freebsd-net@FreeBSD.ORG Sat Jun 13 08:25:22 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13AEF106566C for ; Sat, 13 Jun 2009 08:25:22 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-pz0-f197.google.com (mail-pz0-f197.google.com [209.85.222.197]) by mx1.freebsd.org (Postfix) with ESMTP id CE9828FC1E for ; Sat, 13 Jun 2009 08:25:21 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by pzk35 with SMTP id 35so1729172pzk.3 for ; Sat, 13 Jun 2009 01:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=7KLG1L2Dr6ryuykZZD77hPziPxxKO1HB93mijrcWI48=; b=fWPYdJ6zU/FtPzCXFHw5dzky8d0JjCfZaNmesHBCqT/5yJPTg7jcrj92kZ5OePjAnr Ne2V61C42m2kOcNpn9TZIdcMspSX3BZN8ZnXBADAVFlE6GFE+BPdYEYuOJs61ctd3tzk Vf7034UfY4YHsPBIrirsh/TKY9mz1x7CotOz0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=cw10yTD4jPrten0SXpZ5Vxoky5BtNnK0OIkYKisYk4Rg+V858U4WQawqjSIjSNM78A VfnrIpyw/QMt0xbTul9BiGPINiol3HWLBljVsf9JRpoXuKnw9ohFMAGb9/XngiFq8LSI ClXDPMadb+qhIjkdhkRHtcpV1rM4K9MbXX03Q= MIME-Version: 1.0 Received: by 10.142.44.14 with SMTP id r14mr2014515wfr.221.1244881521537; Sat, 13 Jun 2009 01:25:21 -0700 (PDT) In-Reply-To: <20090613080136.GB76872@michelle.cdnetworks.co.kr> References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <20090612013406.GB72855@michelle.cdnetworks.co.kr> <20090612100900.M22887@maildrop.int.zabbadoz.net> <71535CB2-2784-4253-B67E-017FEAD57637@freebsd.org> <4A32F752.90003@cs.duke.edu> <20090613080136.GB76872@michelle.cdnetworks.co.kr> Date: Sat, 13 Jun 2009 01:25:21 -0700 Message-ID: <2a41acea0906130125u4f6f6124l77e6115264ffb305@mail.gmail.com> From: Jack Vogel To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: FreeBSD net mailing list , Michael Tuexen , Andrew Gallatin Subject: Re: Ethernet NIC drivers depending unconditionally on INET X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2009 08:25:22 -0000 I agree with Michael, I don't want to see this proliferation of capabilities, if you want checksum offload you get it whatever the IP type. Jack On Sat, Jun 13, 2009 at 1:01 AM, Pyun YongHyeon wrote: > On Sat, Jun 13, 2009 at 09:15:06AM +0200, Michael Tuexen wrote: > > On Jun 13, 2009, at 2:48 AM, Andrew Gallatin wrote: > > > > >Michael Tuexen wrote: > > > > > >> I'm not sure if we need additional IFCAP_RXCSUM6 IFCAP_TXCSUM6 > > >> capabilities... Why would we want to enable IPv4 offloading and > > >> not IPv6 or vice versa? > > > > > >I'd assume that some older hardware supports IPv4 offloads, but > > >might not have support for IPv6 offloads. > > Sure. But then the driver only provides the CSUM_ flags which > > are appropriate. For example, a similar thing is already in the > > igb driver: > > > > 1167 if (ifp->if_capenable & IFCAP_TXCSUM) { > > 1168 ifp->if_hwassist |= (CSUM_TCP | CSUM_UDP); > > 1169 #if __FreeBSD_version >= 800000 > > 1170 if (adapter->hw.mac.type == e1000_82576) > > 1171 ifp->if_hwassist |= CSUM_SCTP; > > 1172 #endif > > 1173 } > > That would disable all IPv4/IPv6 checksum offloading if > administrator disable IFCAP_TXCSUM. If we have IFCAP_TXCSUM6/ > IFCAP_RXCSUM6 users could choose best working one even if some part > of driver/controller had checksum offload bugs. > > > > > For FreeBSD 8 and a particular chip, SCTP checksum offloading > > is supported. No need for a special IFCAP_TXCSUM. > > > > Best regards > > Michael > > > > > > > >Drew > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >