From owner-svn-src-head@FreeBSD.ORG  Mon Nov 17 15:28:27 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 89BD5147;
 Mon, 17 Nov 2014 15:28:27 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0E2C23D1;
 Mon, 17 Nov 2014 15:28:26 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sAHFSOcJ030169
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 17 Nov 2014 18:28:24 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sAHFSOvt030168;
 Mon, 17 Nov 2014 18:28:24 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 17 Nov 2014 18:28:24 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: "Alexander V. Chernikov" <melifaro@FreeBSD.org>
Subject: Re: svn commit: r274585 - head/sys/net
Message-ID: <20141117152824.GQ1031@FreeBSD.org>
References: <201411161456.sAGEuWVj029737@svn.freebsd.org>
 <20141117152740.GP1031@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141117152740.GP1031@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2014 15:28:27 -0000

On Mon, Nov 17, 2014 at 06:27:40PM +0300, Gleb Smirnoff wrote:
T> On Sun, Nov 16, 2014 at 02:56:32PM +0000, Alexander V. Chernikov wrote:
T> A> Author: melifaro
T> A> Date: Sun Nov 16 14:56:31 2014
T> A> New Revision: 274585
T> A> URL: https://svnweb.freebsd.org/changeset/base/274585
T> A> 
T> A> Log:
T> A>   Make witness happy: destroy rte lock before free.
T> A>   MFC after:	2 weeks
T> A> Modified:
T> A>   head/sys/net/route.c
T> A> 
T> A> Modified: head/sys/net/route.c
T> A> ==============================================================================
T> A> --- head/sys/net/route.c	Sun Nov 16 13:57:53 2014	(r274584)
T> A> +++ head/sys/net/route.c	Sun Nov 16 14:56:31 2014	(r274585)
T> A> @@ -517,6 +517,7 @@ rtfree(struct rtentry *rt)
T> A>  		/*
T> A>  		 * and the rtentry itself of course
T> A>  		 */
T> A> +		RT_LOCK_DESTROY(rt);
T> A>  		uma_zfree(V_rtzone, rt);
T> A>  		return;
T> A>  	}
T> 
T> This is not right fix. The lock will be destroyed second time by rtentry_zfini().
T> 
T> Can you please point me at revision that introduced the problem, you are
T> trying to solve?

Please ignore me. :) A lag between our yesterday IRC discussion and email.

-- 
Totus tuus, Glebius.