From owner-cvs-src@FreeBSD.ORG  Tue Mar 25 09:10:06 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8F9F937B401; Tue, 25 Mar 2003 09:10:06 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3A83A43F3F; Tue, 25 Mar 2003 09:10:03 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.8/8.12.8) with ESMTP id h2PHA0hV020411;
	Tue, 25 Mar 2003 18:10:01 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Nate Lawson <njl@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 25 Mar 2003 08:21:09 PST."
             <200303251621.h2PGL9Xk070387@repoman.freebsd.org> 
Date: Tue, 25 Mar 2003 18:10:00 +0100
Message-ID: <20410.1048612200@critter.freebsd.dk>
X-Spam-Status: No, hits=-6.5 required=5.0
	tests=IN_REP_TO,QUOTED_EMAIL_TEXT
	version=2.50
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp)
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb umass.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Mar 2003 17:10:09 -0000

In message <200303251621.h2PGL9Xk070387@repoman.freebsd.org>, Nate Lawson write
s:
>njl         2003/03/25 08:21:09 PST
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/dev/usb          umass.c 
>  Log:
>  Add code to implement two new USB quirk types:  NO_INQUIRY and NO_INQUIRY_EVPD
>  The former fakes a valid response to an inquiry command.  (I am completely
>  blown away that there are devices which hang upon receiving inquiry).  The
>  latter returns "invalid request" to any inquiry commands with EVPD set.
>  NO_INQUIRY implies NO_INQUIRY_EVPD but not vice versa.  Both quirks have been
>  tested separately on my USB key although it didn't require either of them.
>  
>  While I'm here, fix wildcarding so that any/all of vendor, product, revision
>  can be wildcarded.

Isn't it time we started loading the quirk table with a userland utility ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.