From owner-p4-projects@FreeBSD.ORG Tue May 11 00:04:19 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 24B0C1065746; Tue, 11 May 2010 00:04:19 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DDAB11065744 for ; Tue, 11 May 2010 00:04:18 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id CC90E8FC0A for ; Tue, 11 May 2010 00:04:18 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4B04IvS093044 for ; Tue, 11 May 2010 00:04:18 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4B04IO0093042 for perforce@freebsd.org; Tue, 11 May 2010 00:04:18 GMT (envelope-from hselasky@FreeBSD.org) Date: Tue, 11 May 2010 00:04:18 GMT Message-Id: <201005110004.o4B04IO0093042@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 178078 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2010 00:04:19 -0000 http://p4web.freebsd.org/@@178078?ac=10 Change 178078 by hselasky@hselasky_laptop001 on 2010/05/11 00:03:19 Back out double-call check from P4 change 178075. This should not be possible from open/close after all. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/usb_hub.c#44 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/usb_hub.c#44 (text+ko) ==== @@ -1230,11 +1230,6 @@ if (udev->flags.usb_mode != USB_MODE_HOST) return; /* not supported */ - if (xfer->flags_int.bandwidth_reclaimed != 0) - return; /* bandwidth already allocated */ - - xfer->flags_int.bandwidth_reclaimed = 1; - xfer->endpoint->refcount_bw++; if (xfer->endpoint->refcount_bw != 1) return; /* already allocated */ @@ -1315,11 +1310,6 @@ if (udev->flags.usb_mode != USB_MODE_HOST) return; /* not supported */ - if (xfer->flags_int.bandwidth_reclaimed == 0) - return; /* bandwidth already freed */ - - xfer->flags_int.bandwidth_reclaimed = 0; - xfer->endpoint->refcount_bw--; if (xfer->endpoint->refcount_bw != 0) return; /* still allocated */