From owner-freebsd-bugs@FreeBSD.ORG  Sun Oct  1 17:32:01 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BD9B816A40F;
	Sun,  1 Oct 2006 17:32:01 +0000 (UTC) (envelope-from ru@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 788C643D49;
	Sun,  1 Oct 2006 17:32:01 +0000 (GMT) (envelope-from ru@FreeBSD.org)
Received: from freefall.freebsd.org (ru@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k91HW1aG004229;
	Sun, 1 Oct 2006 17:32:01 GMT (envelope-from ru@freefall.freebsd.org)
Received: (from ru@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k91HW1OF004225;
	Sun, 1 Oct 2006 17:32:01 GMT (envelope-from ru)
Date: Sun, 1 Oct 2006 17:32:01 GMT
From: Ruslan Ermilov <ru@FreeBSD.org>
Message-Id: <200610011732.k91HW1OF004225@freefall.freebsd.org>
To: ru@FreeBSD.org, freebsd-bugs@FreeBSD.org, csjp@FreeBSD.org
Cc: 
Subject: Re: bin/103873: login(1) SEGFAULT on unsuccessful login
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Oct 2006 17:32:01 -0000

Synopsis: login(1) SEGFAULT on unsuccessful login

Responsible-Changed-From-To: freebsd-bugs->csjp
Responsible-Changed-By: ru
Responsible-Changed-When: Sun Oct 1 17:29:34 UTC 2006
Responsible-Changed-Why: 
Christian did the MFC so he eats all the bugs now.  :-)

The fix proposed in the PR should be replaced by simply MFCing
rev. 1.101 to login.c:

: date: 2006/03/28 15:30:42;  author: cognet;  state: Exp;  lines: +5 -2
: Don't call audit_logout() if pwd is NULL, as audit_logout() attempts to
: dereference it.
: This will happen if we ^D at the Login: prompt without having provided a
: valid login before.
: Set pwd to NULL on bad login attempts to prevent audit_logout() from being
: called for a user which didn't actually log on.
: 
: Reported by:    Jerome Magnin jethro at docisland dot org

http://www.freebsd.org/cgi/query-pr.cgi?pr=103873