From owner-cvs-all@FreeBSD.ORG Mon Jun 20 19:16:29 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B27A516A41C; Mon, 20 Jun 2005 19:16:29 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from www.portaone.com (web.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 259C143D48; Mon, 20 Jun 2005 19:16:28 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from [192.168.0.19] (lesnik.portaone.com [195.140.246.50]) (authenticated bits=0) by www.portaone.com (8.12.11/8.12.11) with ESMTP id j5KJGQw0089130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Jun 2005 21:16:27 +0200 (CEST) (envelope-from sobomax@portaone.com) Message-ID: <42B71604.1000803@portaone.com> Date: Mon, 20 Jun 2005 22:16:20 +0300 From: Maxim Sobolev Organization: Porta Software Ltd User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kirill Ponomarew References: <200506141505.j5EF5hr9001816@repoman.freebsd.org> <42AEFDD0.5060508@portaone.com> <20050614201712.GB21336@voodoo.oberon.net> <20050615040727.GB15096@www.portaone.com> In-Reply-To: <20050615040727.GB15096@www.portaone.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.83/946/Sun Jun 19 10:41:16 2005 on www.portaone.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/pkg_install/add extract.c src/usr.sbin/pkg_install/create pkg_create.1 src/usr.sbin/pkg_install/info show.c src/usr.sbin/pkg_install/lib lib.h plist.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Maxim.Sobolev@portaone.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2005 19:16:29 -0000 Any chance that my concerns will be addressed by the brand new pkg_install maintainer? -Maxim Maxim Sobolev wrote: > Well, while it can have some semantical value, but it is noop > right now due to the absence of upgrade mechanism for older > releases. Nobody will use it until such mechanism is introduced. > > Also, this commit is incomplete since it doesn't include proper > bumps in PKG_INSTALL_VERSION and PLIST_FMT_VER_MAJOR. This > is major plist change since older pkg_install tools will > not be able to handle packages with @noinst. > > Another problem is that the name has been selected poorly IMHO, > since "noinst" doesn't mean "do not install this", but in > fact something like "do not package this", since there is > no point to package some file which isn't going to be installed > anyway. Therefore I'd suggest to change name to nopack along > with version bump. > > -Maxim > > On Tue, Jun 14, 2005 at 10:17:12PM +0200, Kirill Ponomarew wrote: > >>On Tue, Jun 14, 2005 at 06:54:56PM +0300, Maxim Sobolev wrote: >> >>>What's the purpose of such feature? I can't guess any. >> >>The purpose is to separate the meanings of these two fields, I was >>agree with flz that @comment sounds a little strange in relation to >>files, @noinst is more appropriate in this case. However @comment >>will stay anyway and serve for real comments, md5 sums etc. >> >> >>>Kirill Ponomarew wrote: >>> >>>>krion 2005-06-14 15:05:43 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> usr.sbin/pkg_install/add extract.c >>>> usr.sbin/pkg_install/create pkg_create.1 >>>> usr.sbin/pkg_install/info show.c >>>> usr.sbin/pkg_install/lib lib.h plist.c >>>> Log: >>>> Implement @noinst field which has at the moment the same meaning and >>>> function as @comment has. But will be valid only for files and not >>>> for md5 sums, rcsid's and comments in the future. >>>> >>>> Submitted by: flz >>>> Approved by: re@ (scottl) >>>> >>>> Revision Changes Path >>>> 1.43 +2 -1 src/usr.sbin/pkg_install/add/extract.c >>>> 1.66 +10 -0 src/usr.sbin/pkg_install/create/pkg_create.1 >>>> 1.38 +4 -0 src/usr.sbin/pkg_install/info/show.c >>>> 1.56 +2 -1 src/usr.sbin/pkg_install/lib/lib.h >>>> 1.49 +6 -0 src/usr.sbin/pkg_install/lib/plist.c >>>> >>>> >>>> >>> >>-Kirill >> >> > > > >