From owner-freebsd-current@FreeBSD.ORG  Wed Feb  7 17:56:34 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EB66E16A411;
	Wed,  7 Feb 2007 17:56:34 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id A829313C4C2;
	Wed,  7 Feb 2007 17:56:34 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l17HtDku055396;
	Wed, 7 Feb 2007 10:55:18 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <45CA1273.8080205@samsco.org>
Date: Wed, 07 Feb 2007 10:54:59 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <17855.30388.764471.322562@grasshopper.cs.duke.edu>
	<17855.31464.891778.783293@grasshopper.cs.duke.edu>
	<45C0CCFE.5090407@samsco.org> <200702071212.06578.jhb@freebsd.org>
In-Reply-To: <200702071212.06578.jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]);
	Wed, 07 Feb 2007 10:55:18 -0700 (MST)
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: freebsd-current@freebsd.org, Andrew Gallatin <gallatin@cs.duke.edu>
Subject: Re: restoring PCI config space
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2007 17:56:35 -0000

John Baldwin wrote:
> On Wednesday 31 January 2007 12:08, Scott Long wrote:
>> Andrew Gallatin wrote:
>>> Scott Long writes:
>>>  > I need to do the same thing, and I concluded that pci_cfg_restore needs
>>>  > to be exported out via a DEVMETHOD.  It might also be useful to export
>>>
>>> Hurray!  Do you plan to do this soon?
>>>
>>>  > a pci_cfg_save function.
>>>
>>> Doesn't the config space get saved in pci_add_child?
>>>
>>> Drew
>> Wouldn't you want to preserve driver-local changes that are made to the
>> config space?  Things like the busmaster enable bit comes to mind.
> 
> If you use 'pci_enable_busmaster()' then that updates the copy in the dinfo.
> 

Do changes to the MSI/MSIX config space registers also get preserved?

Scott