From owner-freebsd-current  Thu Aug 17 10:23:26 2000
Delivered-To: freebsd-current@freebsd.org
Received: from gatekeeper.whistle.com (gatekeeper.whistle.com [207.76.204.2])
	by hub.freebsd.org (Postfix) with ESMTP id 030EA37BAD3
	for <freebsd-current@freebsd.org>; Thu, 17 Aug 2000 10:23:23 -0700 (PDT)
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by gatekeeper.whistle.com (8.9.3/8.9.3) with ESMTP id KAA08595;
	Thu, 17 Aug 2000 10:23:18 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.3/8.9.3) id KAA94975;
	Thu, 17 Aug 2000 10:23:17 -0700 (PDT)
	(envelope-from archie)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <200008171723.KAA94975@bubba.whistle.com>
Subject: Re: 5.0 snapshot install problem
In-Reply-To: <20000818.005433.112615995.ume@mahoroba.org> from Hajimu UMEMOTO
 at "Aug 18, 2000 00:54:33 am"
To: Hajimu UMEMOTO <ume@mahoroba.org>
Date: Thu, 17 Aug 2000 10:23:17 -0700 (PDT)
Cc: freebsd-current@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL68 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Hajimu UMEMOTO writes:
> archie> I'm having trouble installing the 5.0-20000815-CURRENT snapshot.
> archie> The problem seems to be broken behavior in the installer FTP client.
> archie> My firewall requires using passive mode. The installer asks the
> archie> FTP server for passive mode (using PASV), but then it bogusly asks
> archie> for active mode (using the PORT command) immediately afterwards.
> archie> Yes I selected 'passive mode ftp' for the transfer method.
> 
> It seems -CURRENT's libftpio.c always set passive flag according to
> environment variable FTP_PASSIVE_MODE.  Then, PASV/PORT selection
> obeys only FTP_PASSIVE_MODE and direction of sysinstall is ignored.
> Does this patch fix your problem?

Don't know, because I'd have to create new install floppies first..

But I don't think this patch would fix things.. I don't see any
logical flaw there. ftpPassive() just checks that the toggle is
set to the right value -- it doesn't necessarily do anything.

The only way I can see that PASV would be sent immediately followed
by PORT is due to incorrect logic in the installer (or possibly a
bug in libftpio's parsing of the 227 reply).

-Archie

> Index: lib/libftpio/ftpio.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/libftpio/ftpio.c,v
> retrieving revision 1.37
> diff -u -u -r1.37 ftpio.c
> --- lib/libftpio/ftpio.c	2000/07/10 10:00:20	1.37
> +++ lib/libftpio/ftpio.c	2000/08/17 15:40:43
> @@ -550,7 +550,8 @@
>  {
>      char *cp = getenv("FTP_PASSIVE_MODE");
>  
> -    ftpPassive(fp, (cp && strncasecmp(cp, "no", 2)));
> +    if (cp)
> +	ftpPassive(fp, strncasecmp(cp, "no", 2));
>  }
>  
>  static void

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message