From owner-svn-ports-head@freebsd.org Thu Apr 19 12:07:24 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1242EF9FC0C; Thu, 19 Apr 2018 12:07:24 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D09583E3F; Thu, 19 Apr 2018 12:07:23 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-24-163-43-246.nc.res.rr.com [24.163.43.246]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id w3JC7BUc042834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 19 Apr 2018 12:07:17 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r467762 - head/devel/git To: Renato Botelho , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201804191005.w3JA5jXZ097887@repo.freebsd.org> From: Steve Wills Message-ID: Date: Thu, 19 Apr 2018 08:07:06 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201804191005.w3JA5jXZ097887@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Thu, 19 Apr 2018 12:07:18 +0000 (UTC) X-Spam-Status: No, score=1.3 required=4.5 tests=RCVD_IN_RP_RNBL autolearn=no autolearn_force=no version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 12:07:24 -0000 Hi, Glad you bumped PORTREVISION but the commit message implies you didn't need to if the GITWEB option wasn't on by default. The Porters handbook disagrees: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way. That includes changes that only affect a package built with non-default options. Just picking a random instance here since you're not the only one who has thought this. So I point it out to everyone for future reference. Steve On 04/19/2018 06:05, Renato Botelho wrote: > Author: garga > Date: Thu Apr 19 10:05:44 2018 > New Revision: 467762 > URL: https://svnweb.freebsd.org/changeset/ports/467762 > > Log: > - Register p5-CGI dependency when GITWEB option is enabled [1] > - Bump PORTREVISION since GITWEB is on by default > - While here, unmute install command and make portlint happy > > PR: 225358 [1] > Submitted by: Fabian Kell [1] > MFH: 2018Q2 > Sponsored by: Rubicon Communications, LLC (Netgate) > > Modified: > head/devel/git/Makefile > > Modified: head/devel/git/Makefile > ============================================================================== > --- head/devel/git/Makefile Thu Apr 19 10:02:45 2018 (r467761) > +++ head/devel/git/Makefile Thu Apr 19 10:05:44 2018 (r467762) > @@ -3,6 +3,7 @@ > > PORTNAME= git > DISTVERSION= 2.17.0 > +PORTREVISION= 1 > CATEGORIES= devel > MASTER_SITES= KERNEL_ORG/software/scm/git > DISTFILES= ${DISTNAME}${EXTRACT_SUFX} \ > @@ -74,6 +75,7 @@ PERL_RUN_DEPENDS= p5-Error>=0:lang/p5-Error > PERL_MAKE_ARGS_OFF= NO_PERL=1 > > GITWEB_IMPLIES= PERL > +GITWEB_RUN_DEPENDS= p5-CGI>=0:www/p5-CGI > > PCRE_LIB_DEPENDS= libpcre.so:devel/pcre > PCRE_CONFIGURE_WITH= libpcre > @@ -226,7 +228,7 @@ post-install-CONTRIB-on: > post-install-CONTRIB-off: > # Install the contrib completions anyway > @${MKDIR} ${STAGEDIR}${PREFIX}/etc/bash_completion.d > - @${INSTALL_SCRIPT} ${WRKSRC}/contrib/completion/git-completion.bash \ > + ${INSTALL_SCRIPT} ${WRKSRC}/contrib/completion/git-completion.bash \ > ${STAGEDIR}${PREFIX}/etc/bash_completion.d/git.sh > > post-install-P4-on: >