From owner-freebsd-gnome@FreeBSD.ORG Thu Mar 10 07:07:46 2011 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCEF7106564A; Thu, 10 Mar 2011 07:07:46 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id BB26D8FC0C; Thu, 10 Mar 2011 07:07:45 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA17693; Thu, 10 Mar 2011 09:07:43 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PxZyJ-000FnH-63; Thu, 10 Mar 2011 09:07:43 +0200 Message-ID: <4D7878BD.9020802@freebsd.org> Date: Thu, 10 Mar 2011 09:07:41 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110308 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: kde@freebsd.org, gnome@freebsd.org References: <4D692B50.4000807@freebsd.org> In-Reply-To: <4D692B50.4000807@freebsd.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=x-viet-vps Content-Transfer-Encoding: 7bit Cc: Subject: Re: icon for optical disk X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2011 07:07:46 -0000 on 26/02/2011 18:33 Andriy Gapon said the following: > > Very minor issue really. > Whatever kind of optical disk I insert KDE 4 just shows its label, but never a > nice-looking icon. > Examples with a CD-RW disk: > http://people.freebsd.org/~avg/cd-noicon.png > http://people.freebsd.org/~avg/cd-noicon1.png > "TRANT rXXXX" is a label of an ISO filesystem on the disk. > > Am I alone with this issue? I guess that I wasn't but everyone is too busy (embarassed?) to discuss this issue :) So it seems that the problem is between the solid library and our hal. In kdelibs4, in the file solid/solid/backends/hal/haldevice.cpp, there is the function 'QString HalDevice::icon() const' that returns an icon name based on information that hal provides about a device. The function expects that for optical disks "info.category" would be "volume" and "info.capabilities" would contain "volume.disc". But our hal gives "volume.disc" value in the info.category property as I can see with lshal. And thus the match fails and an empty icon name is returned from the function. I've just double-checked with OpenSUSE installation that I have and their hal supplies the values that the solid code expects. BTW, the similar mismatch exists also for an optical drive itself. With linux hal info.category is "storage" and info.capabilities contains "storage.cdrom", but with our hal info.category is "storage.cdrom". Not sure if the upcoming KDE 4.6.1 will be affected (i.e. if it still uses hal backend). But I think that our hal is still worth fixing. Thanks! -- Andriy Gapon