From owner-cvs-src@FreeBSD.ORG Tue May 13 08:23:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CADF737B425; Tue, 13 May 2003 08:23:49 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C4D543F85; Tue, 13 May 2003 08:23:48 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 0A654530E; Tue, 13 May 2003 17:23:46 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "M. Warner Losh" References: <20030513.083546.133906327.imp@bsdimp.com> <20030513.091023.35039296.imp@bsdimp.com> From: Dag-Erling Smorgrav Date: Tue, 13 May 2003 17:23:45 +0200 In-Reply-To: <20030513.091023.35039296.imp@bsdimp.com> (M. Warner Losh's message of "Tue, 13 May 2003 09:10:23 -0600 (MDT)") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii cc: joe@FreeBSD.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: obrien@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2003 15:23:51 -0000 "M. Warner Losh" writes: > OK. I'll use your stuff and merge it into the bigger mii/pccard > picture. I see why it works, but it is a little different than the > foo_if.h stuff, which we have to list explicitly... Yes, it's a hack taking advantage of the fact that everything that relates to USB includes opt_usb.h... I did it precisely to avoid having to modify the module Makefiles. It's ugly as sin though, and changing the Makefiles to explicitly list usbdevs.h is probably better in the long run. One other thing: my patch does not add usbdevs{,_data}.h to CLEANFILES, which it should - but doing it unconditionally is kinda yucky, and I can't see a way to do it conditionally. We should probably have something in kmod.mk similar to the USE_* stuff in bsd.port.mk - USE_MII, USE_USB, etc. DES -- Dag-Erling Smorgrav - des@ofug.org