Date: Tue, 13 May 2003 17:23:45 +0200 From: Dag-Erling Smorgrav <des@ofug.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: obrien@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c usbdevs Message-ID: <xzpel32dg5a.fsf@flood.ping.uio.no> In-Reply-To: <20030513.091023.35039296.imp@bsdimp.com> (M. Warner Losh's message of "Tue, 13 May 2003 09:10:23 -0600 (MDT)") References: <xzphe7zmb45.fsf@flood.ping.uio.no> <20030513.083546.133906327.imp@bsdimp.com> <xzpissedgtp.fsf@flood.ping.uio.no> <20030513.091023.35039296.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"M. Warner Losh" <imp@bsdimp.com> writes:
> OK. I'll use your stuff and merge it into the bigger mii/pccard
> picture. I see why it works, but it is a little different than the
> foo_if.h stuff, which we have to list explicitly...
Yes, it's a hack taking advantage of the fact that everything that
relates to USB includes opt_usb.h... I did it precisely to avoid
having to modify the module Makefiles. It's ugly as sin though, and
changing the Makefiles to explicitly list usbdevs.h is probably better
in the long run.
One other thing: my patch does not add usbdevs{,_data}.h to
CLEANFILES, which it should - but doing it unconditionally is kinda
yucky, and I can't see a way to do it conditionally.
We should probably have something in kmod.mk similar to the USE_*
stuff in bsd.port.mk - USE_MII, USE_USB, etc.
DES
--
Dag-Erling Smorgrav - des@ofug.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpel32dg5a.fsf>