From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 27 17:20:06 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E63ED1065672 for ; Sun, 27 May 2012 17:20:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B6ED38FC12 for ; Sun, 27 May 2012 17:20:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4RHK6sv007443 for ; Sun, 27 May 2012 17:20:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4RHK6a0007442; Sun, 27 May 2012 17:20:06 GMT (envelope-from gnats) Resent-Date: Sun, 27 May 2012 17:20:06 GMT Resent-Message-Id: <201205271720.q4RHK6a0007442@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nicolas Raspail Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 438F31065670 for ; Sun, 27 May 2012 17:11:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 2E86C8FC18 for ; Sun, 27 May 2012 17:11:29 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4RHBS2l062233 for ; Sun, 27 May 2012 17:11:28 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q4RHBSmF062232; Sun, 27 May 2012 17:11:28 GMT (envelope-from nobody) Message-Id: <201205271711.q4RHBSmF062232@red.freebsd.org> Date: Sun, 27 May 2012 17:11:28 GMT From: Nicolas Raspail To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/168382: pecl-uploadprogress - compilation failed with php 5.4 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2012 17:20:07 -0000 >Number: 168382 >Category: ports >Synopsis: pecl-uploadprogress - compilation failed with php 5.4 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 27 17:20:05 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Nicolas Raspail >Release: 9.0-RELEASE >Organization: >Environment: FreeBSD dodger.whisperingvault.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Hi When trying to update from php 5.3 to php 5.4, the compilation of pecl-uploadprogress (from 1.0.1 to 1.0.2) has failed with the following error /usr/ports/devel/pecl-uploadprogress/work/uploadprogress-1.0.2/uploadprogress.c:460: error: 'struct _php_core_globals' has no member named 'magic_quotes_runtime' *** Error code 1 I have found the following message http://permalink.gmane.org/gmane.comp.php.pecl.cvs/14722 and after having created the patch, the compilation was ok. >How-To-Repeat: After having php upgraded to 5.4, try to compile pecl-uploadprogress-1.0.2 >Fix: Put the attached patch in /usr/ports/devel/pecl-uploadprogress/files (remove the .txt part) and install the port Patch attached with submission follows: --- uploadprogress.c.orig 2012-05-27 18:32:23.891923716 +0200 +++ uploadprogress.c 2012-05-27 18:33:33.601926257 +0200 @@ -457,11 +457,12 @@ /* uses mmap if possible */ if ((len = php_stream_copy_to_mem(stream, &contents, maxlen, 0)) > 0) { +#if PHP_API_VERSION < 20100412 if (PG(magic_quotes_runtime)) { contents = php_addslashes(contents, len, &newlen, 1 TSRMLS_CC); len = newlen; } - +#endif RETVAL_STRINGL(contents, len, 0); } else if (len == 0) { RETVAL_EMPTY_STRING(); >Release-Note: >Audit-Trail: >Unformatted: