From owner-freebsd-doc  Fri Mar  7  8:26:47 2003
Delivered-To: freebsd-doc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 304CE37B401; Fri,  7 Mar 2003 08:26:45 -0800 (PST)
Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6DEA743F75; Fri,  7 Mar 2003 08:26:43 -0800 (PST)
	(envelope-from keramida@freebsd.org)
Received: from gothmog.gr (patr530-b220.otenet.gr [212.205.244.228])
	by mailsrv.otenet.gr (8.12.8/8.12.8) with ESMTP id h27GQcNJ006087;
	Fri, 7 Mar 2003 18:26:39 +0200 (EET)
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.12.8/8.12.8) with ESMTP id h27GQZMC004816;
	Fri, 7 Mar 2003 18:26:38 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from giorgos@localhost)
	by gothmog.gr (8.12.8/8.12.8/Submit) id h27FmGD3004393;
	Fri, 7 Mar 2003 17:48:16 +0200 (EET)
	(envelope-from keramida@FreeBSD.org)
Date: Fri, 7 Mar 2003 17:48:16 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
Cc: doc@freebsd.org, ports@freebsd.org
Subject: Re: Porter's Handbook: psutils-{a4,letter} not example for PKGNAMESUFFIX
Message-ID: <20030307154816.GG2094@gothmog.gr>
References: <20030305135958.GA86534@i2.informatik.rwth-aachen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; x-action=pgp-signed
Content-Disposition: inline
In-Reply-To: <20030305135958.GA86534@i2.informatik.rwth-aachen.de>
Sender: owner-freebsd-doc@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-doc.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-doc>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-doc>
X-Loop: FreeBSD.org

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2003-03-05 14:59, Volker Stolz <stolz@i2.informatik.rwth-aachen.de> wrote:
> The porter's handbook mentions as an example on naming conventions
> psutils with a PKGNAMESUFFIX of -letter as hardcoded default.
> The current psutils-port looks different (now?) and doesn't use
> PKGNAMESUFFIX at all. Instead, there are two different ports,
> print/psutils-a4 & print/psutils-letter.
>
> I suggest to change this example to e.g. audio/mpg123, where
> PKGNAMESUFFIX is indeed used as implied by the handbook.
>
> [Cc:ed to ports@, please f'up to doc@freebsd.org]

Good catch.  I can't find after a very quick look at the CVS logs when
psutils was using PKGNAMESUFFIX, but the following seems like a simple
change to make.  Does this look okay?

: Index: book.sgml
: ===================================================================
: RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
: retrieving revision 1.288
: diff -u -r1.288 book.sgml
: --- book.sgml	4 Mar 2003 12:46:59 -0000	1.288
: +++ book.sgml	7 Mar 2003 15:40:26 -0000
: @@ -1157,12 +1157,12 @@
:              </row>
:  
:              <row>
: -              <entry>psutils-1.13</entry>
: +              <entry>mpg123-0.59r</entry>
:                <entry>(empty)</entry>
: -              <entry>psutils</entry>
: -              <entry>-letter</entry>
: -              <entry>1.13</entry>
: -              <entry>Papersize hardcoded at package build time</entry>
: +              <entry>mpg123</entry>
: +              <entry>-esound</entry>
: +              <entry>0.59r</entry>
: +              <entry>Gnome esound support is enabled</entry>
:              </row>
:  
:              <row>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+aL9A1g+UGjGGA7YRAiKwAJ9Fh1Dmd4wuCV4rXd+aYl0RaQHkVgCfeN39
L7nFSDVJw8K0Hpas6SblHZI=
=X8bp
-----END PGP SIGNATURE-----

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message