From owner-freebsd-current@FreeBSD.ORG Mon Nov 12 14:20:21 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 227A216A417 for ; Mon, 12 Nov 2007 14:20:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id C016913C4C4 for ; Mon, 12 Nov 2007 14:20:20 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1Ira90-000Jb7-Us; Mon, 12 Nov 2007 16:20:07 +0200 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id lACEK0ob035332; Mon, 12 Nov 2007 16:20:00 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id lACEJxqO035331; Mon, 12 Nov 2007 16:19:59 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 12 Nov 2007 16:19:59 +0200 From: Kostik Belousov To: Nikolay Pavlov Message-ID: <20071112141959.GP37471@deviant.kiev.zoral.com.ua> References: <20070917194009.W84177@woozle.rinet.ru> <200709241223.52140.qpadla@gmail.com> <472561A7.60108@delphij.net> <200711121433.26356.qpadla@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wJnDPJhqGGlzIm5V" Content-Disposition: inline In-Reply-To: <200711121433.26356.qpadla@gmail.com> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: 565941832c2f675ae953af64aa3a5396 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1766 [Nov 12 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: freebsd-current@freebsd.org, delphij@freebsd.org, Dmitry Morozovsky Subject: Re: tmpfs on contemporary -current: panic: locked against myself X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2007 14:20:21 -0000 --wJnDPJhqGGlzIm5V Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 12, 2007 at 02:33:22PM +0200, Nikolay Pavlov wrote: > On Monday 29 October 2007 06:29:27 LI Xin wrote: > > > Just want to be sure that no one lose this. Here is a PR: > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D116600 > > > > Can not reproduce here. =9ACould you please confirm that this still > > persists for latest RELENG_7? >=20 > Look like i've got it finally. The exact option the cause a panic for me = is=20 > a "mode=3D777". So that: > mount -t tmpfs tmpfs /tmp - works fine. =20 > mount -t tmpfs -o mode=3D777 tmpfs /tmp - triggers a panic. > A backtrace and a message are the same as in PR. 7.0-BETA2 is affected to= o. The following patch fixed it for me. diff --git a/sys/fs/tmpfs/tmpfs_vfsops.c b/sys/fs/tmpfs/tmpfs_vfsops.c index 4a3cdec..55e9891 100644 --- a/sys/fs/tmpfs/tmpfs_vfsops.c +++ b/sys/fs/tmpfs/tmpfs_vfsops.c @@ -201,7 +201,7 @@ tmpfs_mount(struct mount *mp, struct thread *td) /* Root node attributes. */ uid_t root_uid; gid_t root_gid; - mode_t root_mode; + int root_mode; =20 struct vattr va; =20 --wJnDPJhqGGlzIm5V Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHOGEPC3+MBN1Mb4gRAgmDAKDEL4P6HqEd9FC0+f1QjA8ybtkDzACgitaf aoOSRLzlqCgrZXwYa2t6thY= =0OCb -----END PGP SIGNATURE----- --wJnDPJhqGGlzIm5V--