From owner-cvs-src@FreeBSD.ORG Tue Feb 26 12:57:22 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2D951065676; Tue, 26 Feb 2008 12:57:22 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 8BEEE13C428; Tue, 26 Feb 2008 12:57:22 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 740BC2098; Tue, 26 Feb 2008 13:57:11 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.3/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id E76F82092; Tue, 26 Feb 2008 13:57:09 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Robert Watson References: <200802250855.m1P8t3w6052042@repoman.freebsd.org> <47C29A07.2070908@FreeBSD.org> <86d4qli8a1.fsf@ds4.des.no> <20080226123107.N90776@fledge.watson.org> Date: Tue, 26 Feb 2008 13:57:09 +0100 In-Reply-To: <20080226123107.N90776@fledge.watson.org> (Robert Watson's message of "Tue\, 26 Feb 2008 12\:33\:31 +0000 \(GMT\)") Message-ID: <86r6ezswnu.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, Kris Kennaway , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" Subject: Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vnode_if.src src/sys/sys mount.h vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2008 12:57:23 -0000 Robert Watson writes: > Dag-Erling Sm=C3=B8rgrav writes: > > No, it changes neither the API nor the ABI. It replaces caddr_t > > (which is typedef'd to char *) with void *, and those two are > > compatible types. > I'm sorry, but I disagree. The case you failed to test involves a > function pointer typedef. Umm, OK, I didn't spot that. It's unfortunate that David didn't change our own file system code to match (or even build LINT, which would have shown him the problem), so that RELENG_6 current doesn't build. Still, I would argue for fixing the code rather than reverting the change. > Here's the test I had to add to Arla to detect the change with > autoconf; without this autoconf mess and changed prototypes in the > Arla nnpfs code, I can't build nnpfs on -CURRENT, and presumably now > also on our -STABLE branches: Arguably, Arla has been broken for more than two years and you only just woke up and noticed. If you had tried to build Arla on -CURRENT at any point since 2005/12/14, you would have noticed and presumably fixed it. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no