From owner-cvs-all@FreeBSD.ORG  Mon Jul 31 13:15:20 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 60DC916A51A;
	Mon, 31 Jul 2006 13:15:20 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EDA0643D58;
	Mon, 31 Jul 2006 13:15:06 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k6VDF3ZC001830
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 31 Jul 2006 17:15:03 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.4/8.13.1/Submit) id k6VDF30Z001829;
	Mon, 31 Jul 2006 17:15:03 +0400 (MSD)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Mon, 31 Jul 2006 17:15:02 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Pyun YongHyeon <yongari@FreeBSD.org>
Message-ID: <20060731131502.GS96644@FreeBSD.org>
References: <200607200357.k6K3vwg2039627@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200607200357.k6K3vwg2039627@repoman.freebsd.org>
User-Agent: Mutt/1.5.6i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/em if_em.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2006 13:15:20 -0000

On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote:
P> yongari     2006-07-20 03:57:58 UTC
P> 
P>   FreeBSD src repository
P> 
P>   Modified files:
P>     sys/dev/em           if_em.c 
P>   Log:
P>   Honor IFF_DRV_OACTIVE in em_start_locked().

Isn't it better to shift this change to the em_start(), to avoid
double check of IFF_DRV_RUNNING? Or may be just merge em_start_locked()
into the em_start()?

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE