From owner-freebsd-current@freebsd.org Sat Dec 2 15:44:29 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83F92E5D837 for ; Sat, 2 Dec 2017 15:44:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4978F74577 for ; Sat, 2 Dec 2017 15:44:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x229.google.com with SMTP id d21so14319356ioe.7 for ; Sat, 02 Dec 2017 07:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ryW9y9uxDy8g4962ZPvSznCJGNzUaNSpV/dokMr6iP4=; b=eWuf9gWtQCZkcgp7qa9NmH3F1N8kMWo7aIW2Dgpv3qoqO2rS6r1rXy8eFHYiK7qOQo YNIzk+Pmj3ntKc4sMa6AumjJPxSWEQ6kS1WZOFwjpWDpww0kCbXZ3jdrcyZeIHjbydfF yRKmtDqqMwIz2kWi9PSIvXFQww0Zgvf5GY0dUflB24ZEbGPfayI+XTQINzOzsC6203Xl pMJ37BWT8yD5erPyNadTpEFfDn3D6ed5APcskDeDh15O8SvrrvOZWHNPmfnMMRZ3AuaY dOojmpwLWhuDfF4u3L53kEgDAaPgxJZTmaM6o9dWBkIKBbzbpsOQG+Arh1VH1zm3pgC3 dd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ryW9y9uxDy8g4962ZPvSznCJGNzUaNSpV/dokMr6iP4=; b=QWbukcQcjKD6XaKkIcWs6pU3XvS5OisyLNK8iKcFSEJHvRf2+tKoc32cU7uFRah2SQ C++4UBDmbdIatRwYmpJrZQwqPF+CtkZtlnT+P9xcdyR7/skEFul7xxg23TEASwDRoBlA tN9r1uQ1WojZu5ZDr4ir8456YTA5mgFKQJRzYtJWi4Wnca/9DWpQON3BckXN8oup7mmu iN3fv2M0ZuXUdqtqidX8s8DAr97ZqaGkSH5f96Ov8w1FoTimNiJU45y4uMb1QszVTxpQ QPEZcvgd9NIAkzbZ/D3z2dhVgC0YpxndaYqgagmBniYYyk57D2hHbWZZaj5gP7vheERy NR4w== X-Gm-Message-State: AJaThX4AUVaUWBYHG5sx5ceNRyF342rwEMbRFr32fp8PWkZ6HHRWqpQR cIIMaDAiBL4+HgoXzIv0PCk/dUSwiQ5yyfjfTyuhSQ== X-Google-Smtp-Source: AGs4zMYrkUCgLlAmTh4vPnX92ITYrg2p2SVByrfsDk9I2d6fuB+p+2sVhq1WtMlAQV/7gg0430gkx++xZwpAVfjrtqM= X-Received: by 10.107.48.197 with SMTP id w188mr17529420iow.301.1512229468521; Sat, 02 Dec 2017 07:44:28 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Sat, 2 Dec 2017 07:44:27 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: From: Warner Losh Date: Sat, 2 Dec 2017 08:44:27 -0700 X-Google-Sender-Auth: D1Fj6t7PqL2gd65YdQCSRLyhuI0 Message-ID: Subject: Re: SVN r326458 breaks efivar To: Michael Butler Cc: Warner Losh , freebsd-current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Dec 2017 15:44:29 -0000 On Sat, Dec 2, 2017 at 7:58 AM, Michael Butler wrote: > The introduction of efivar-dp-xlate.c into libefivar requires functions > from libgeom yet usr.sbin/efvar doesn't link with it, > Yup. I didn't think it would need it since efivar doesn't reference those new functions, so I didn't test it before the commit. I'd had a mental note to do it, but just didn't. My bad. Fixed now in r326472. Warner