Date: Mon, 19 Dec 2016 18:37:17 +0100 From: Hans Petter Selasky <hps@selasky.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310242 - head/sys/dev/usb Message-ID: <57d2d5e2-1b2d-09d5-41e2-92b6f22fb229@selasky.org> In-Reply-To: <2058091.PnquSlH0qI@ralph.baldwin.cx> References: <201612190928.uBJ9SDFc078376@repo.freebsd.org> <2058091.PnquSlH0qI@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/19/16 17:13, John Baldwin wrote: > On Monday, December 19, 2016 09:28:13 AM Hans Petter Selasky wrote: >> Author: hselasky >> Date: Mon Dec 19 09:28:12 2016 >> New Revision: 310242 >> URL: https://svnweb.freebsd.org/changeset/base/310242 >> >> Log: >> Defer USB enumeration until the SI_SUB_KICK_SCHEDULER is executed to avoid >> boot panics in conjunction with the recently added EARLY_AP_STARTUP feature. >> The panics happen due to using kernel facilities like callouts too early. >> >> Tested by: jhb @ >> MFC after: 1 week > > As mentioned in the thread, the patches to usb_hub.c weren't needed and the block > in usb_process.c can just be removed unconditionally since it should never execute > in the non-EARLY_AP_STARTUP case. > Hi John, The checks in usb_process.c are needed in case attaching a USB controller fails for some unknown reason. Then there is a problem that thread0 cannot wait/sleep for the process to exit, so that it doesn't access freed memory. Did I miss anything? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57d2d5e2-1b2d-09d5-41e2-92b6f22fb229>