From owner-freebsd-ports@FreeBSD.ORG Wed Jun 2 06:56:31 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBCDA16A4D1 for ; Wed, 2 Jun 2004 06:56:31 -0700 (PDT) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2E7243D39 for ; Wed, 2 Jun 2004 06:56:31 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (a43ec912f5b62b3c5270b8aa2167e7ef@adsl-67-115-73-128.dsl.lsan03.pacbell.net [67.115.73.128]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i52DuRfY026046; Wed, 2 Jun 2004 06:56:27 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id ECEEF51A33; Wed, 2 Jun 2004 06:56:25 -0700 (PDT) Date: Wed, 2 Jun 2004 06:56:25 -0700 From: Kris Kennaway To: Oliver Eikemeier Message-ID: <20040602135625.GA56115@xor.obsecurity.org> References: <20040602121648.GA51625@xor.obsecurity.org> <40BDCC4B.9000708@fillmore-labs.com> <20040602132149.GA55452@xor.obsecurity.org> <40BDD8B6.80103@fillmore-labs.com> <20040602134340.GA55881@xor.obsecurity.org> <40BDDB39.9090106@fillmore-labs.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline In-Reply-To: <40BDDB39.9090106@fillmore-labs.com> User-Agent: Mutt/1.4.2.1i cc: ports@FreeBSD.org cc: Kris Kennaway Subject: Re: INDEX patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 13:56:32 -0000 --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 02, 2004 at 03:50:49PM +0200, Oliver Eikemeier wrote: > >>Because test is a sh-builtin, and the file system should cache this=20 > >>information > >>I don't expect to see any difference. Especially since spawning perl=20 > >>11000 times > >>is more than suboptimal ;) You didn't mean this serious, did you? > > > >I did, because I care about small pessimizations of the INDEX build. > >Sometimes they're not small. Did you benchmark it? >=20 > No. Did you?=20 I did, actually. Removing the ECHO_CMD is a small but measurable improvement (and not negligible when the total index build time is only 120 seconds, which I've achieved with other optimizations). This is a silly argument though, because you just need to test for the existence of perl once in /usr/ports/Makefile. > Honestly, when you really want to improve INDEX building=20 > times, it > should be worth thinking about not spawning perl every time, but instead = do=20 > the > substitutions in batch. I my experience microoptimization on the expense = of > clarity and prudence almost always result in highly optimized suboptimal > algorithms that together run far slower that they have to. This sounds like a good idea for future improvement. Can you take a look at implementing it? Kris --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAvdyJWry0BWjoQKURAm2tAKC/WvBgr9AsQPAWsfir851INHBlvwCfRNsF +W1ISzcwZe34Pq5lUFkfdkI= =c6AL -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--