From owner-freebsd-ports@freebsd.org Sat Dec 29 22:34:35 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD4D5142F274 for ; Sat, 29 Dec 2018 22:34:35 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc31.google.com (mail-yw1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 50A158812D for ; Sat, 29 Dec 2018 22:34:34 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc31.google.com with SMTP id t13so9496916ywe.13 for ; Sat, 29 Dec 2018 14:34:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+f7u4DvOvSGdsn+F1bzGA5jNrwPHhuiRg5MVxdqJwcY=; b=oUsRw+0G+nziCrYKDYqzfmsv3ARf7bEfRiGrZDef5puZNyJ7MYUFVRNmsCPhtSgJ5D 9Sv7RFmtKhGlIMd89TZJKwuIaFVv9tRJJqGLwNZD+vN+BNEzPct8gaOrdVQB8JAlm8ZD JhCbmLozkvMi5tQAmQXoulQEqofr1D/0f3dVBjvkA3Vl3/ZW4dWdEK+z9PXfne4F4dRJ mAaAhRFyNH/KsI/F+ylrNgMRCdJwfNHorRokIOPJB078uAbzkRfceqxcupmaoXQbivw2 Y4Rq0RiniwTR/sWkfHkPoDe8Y4dsL2rVo36LU/yaCa0vL8Jixo5HvMMXruKnZCL/vvmv N0xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+f7u4DvOvSGdsn+F1bzGA5jNrwPHhuiRg5MVxdqJwcY=; b=AFt4T1vRyi4obaKLAbM3/JsWXN7anOEQp5bnb9umkGmYTDGuB6prFqmYBdVz9bhTWX 8MfLuzUR6qsDempAOz/K60i1ht5UAzLehI6A9DVPbYDVM61lI/xDwbjh0fgXwHiHIxfm VJfRRN6vVIgb/lqcreGQadXCyRTUfXQ9FCg0v7AqwBtah88kQR4mJZh8JQVU0gHI1yP1 kVg3zycxtdZIPzexV7kyWacii2Gg27U8pIn6+QAe5zbzGARcXb7tIVG+5wC6s6lcv71R 5JJTmxa6UVompEmITZHSA/iSovSDRdAJv6g8KQxc/KBhtVcAt4qJStom23R8dw9XjUuU 3k7g== X-Gm-Message-State: AA+aEWa/TS4dTRROO7KuKha8lNtntaDM6QBt2u55rBAfO3TtpWjcULyy ZoD+fvKpgpnOiP3pHJf0buyDw0SeJSyEsqoauYLlKG0q8sg= X-Google-Smtp-Source: AFSGD/VVt4Sv4Zrin44pcQ2TmXUnmtXFadIIK8o9c/SU3YhUecqeMAu/Ms1x1jG062trEWq9wMnY6dm6s97aYNLztvY= X-Received: by 2002:a81:31d5:: with SMTP id x204mr33433925ywx.141.1546122873282; Sat, 29 Dec 2018 14:34:33 -0800 (PST) MIME-Version: 1.0 References: <20181229.134412.1093009159948437947.yasu@utahime.org> In-Reply-To: <20181229.134412.1093009159948437947.yasu@utahime.org> From: Adam Weinberger Date: Sat, 29 Dec 2018 15:34:17 -0700 Message-ID: Subject: Re: Request for help: remove bundler from ruby 2.6 port To: Yasuhiro KIMURA Cc: freebsd-ports@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 50A158812D X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=oUsRw+0G; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2607:f8b0:4864:20::c31 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; DMARC_NA(0.00)[adamw.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[1.3.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[alt1.aspmx.l.google.com,alt4.aspmx.l.google.com,alt3.aspmx.l.google.com,alt2.aspmx.l.google.com,aspmx.l.google.com]; IP_SCORE(-0.70)[ipnet: 2607:f8b0::/32(-1.90), asn: 15169(-1.53), country: US(-0.08)]; NEURAL_HAM_SHORT(-0.78)[-0.783,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2018 22:34:35 -0000 On Sat, Dec 29, 2018 at 6:20 AM Yasuhiro KIMURA wrote: > > Hello all, > > Ruby 2.6.0 is released and I tried porting it. > > After creating start point by 'svn copy lang/ruby25 lang/ruby26', I > made following changes. > > https://www.utahime.org/FreeBSD/ports/lang_ruby26.patch > > It is build successfully and works fine on 12.0-RELEASE amd64. But > there is still one issue left. > > From 2.6.0 ruby includes 'bundler'. But according to the convention of > ruby port it should be removed from ruby core port in the same way as > 'gem' and 'rake'. I learned from Makefile that it is achieved by > removing related files from source tree at post-patch target. However > I don't know enough about what files need to be removed to cleanly > remove bundler from ruby 2.6 port. > > So would someone please help me about it? I think perhaps it's worth considering doing the opposite and, beginning with 2.6, install the entire standard library by default. Gems and stdlib exist side-by-side without problem, and many of the gems that are deleted are generally kept up-to-date. Even if we don't want to install the entire standard library, I'd at least strongly argue for including the most important gems (rake, gem, minitest, and bundler) by default. They are basic components of ruby itself, and ports should provide //optional// newer versions of them. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org