Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Nov 2013 09:29:57 +0100
From:      Matthias Andree <mandree@FreeBSD.org>
To:        novel@freebsd.org
Cc:        gnome@FreeBSD.org
Subject:   further libgnome-keyring issues (minor)
Message-ID:  <52775B05.2090402@FreeBSD.org>

next in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--B9f05pwjk75E8OGLdROdOijNAC0VV80l3
Content-Type: multipart/mixed;
 boundary="------------070005040305000303020800"

This is a multi-part message in MIME format.
--------------070005040305000303020800
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Thanks for fixing the dependency.

However, there are still warnings:

> [mandree@apollo /usr/ports.svn/security/libgnome-keyring]$ make
> /!\ libgnome-keyring-2.32.0_6: Makefile warnings, please consider fixin=
g /!\
>=20
> USE_GMAKE is deprecated, consider using USES=3Dgmake
> USE_GNOME=3Dgnomehack is deprecated, please use USES=3Dpathfix
> Please use the new format for LIB_DEPENDS, see handbook for details
>=20
> =3D=3D=3D> Fetching all distfiles required by libgnome-keyring-2.32.0_6=
 for building
=2E..

You can enable these warnings with

	echo >>/etc/make.conf DEVELOPER=3Dyes

Please review the attached patch, which fixes all of them, and apply if
you deem it fit. Note this will require run-time testing, but I have not
yet done that.

Thank you.

Best regards
Matthias

--------------070005040305000303020800
Content-Type: text/plain; charset=UTF-8;
 name="patch-security_libgnome-keyring"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="patch-security_libgnome-keyring"

Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- Makefile	(revision 332671)
+++ Makefile	(working copy)
@@ -10,13 +10,12 @@
 MAINTAINER=3D	gnome@FreeBSD.org
 COMMENT=3D	Program that keeps passwords and other secrets
=20
-LIB_DEPENDS=3D    tasn1.7:${PORTSDIR}/security/libtasn1 \
-                gcrypt:${PORTSDIR}/security/libgcrypt
+LIB_DEPENDS=3D	libtasn1.so:${PORTSDIR}/security/libtasn1 \
+		libgcrypt.so:${PORTSDIR}/security/libgcrypt
=20
 USE_BZIP2=3D	yes
-USE_GNOME=3D	gnomehack gnomeprefix ltverhack intlhack gconf2
-USE_GMAKE=3D	yes
-USES=3D		gettext pkgconfig
+USE_GNOME=3D	gnomeprefix ltverhack intlhack gconf2
+USES=3D		gettext pkgconfig gmake pathfix
 USE_AUTOTOOLS=3D	libtool
 USE_LDCONFIG=3D	yes
 CPPFLAGS+=3D	-I${LOCALBASE}/include

--------------070005040305000303020800--

--B9f05pwjk75E8OGLdROdOijNAC0VV80l3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlJ3WwYACgkQvmGDOQUufZV/cgCeK+y+2BHsV26Ey9XF3gJJnAU9
r/QAoIzNdrVkZLT9DNyMbYbg8xAqIQsv
=0x07
-----END PGP SIGNATURE-----

--B9f05pwjk75E8OGLdROdOijNAC0VV80l3--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52775B05.2090402>