From owner-dev-commits-src-main@freebsd.org Mon Feb 8 23:29:28 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13E4C545C97 for ; Mon, 8 Feb 2021 23:29:28 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DZMgC6qSqz3KKT for ; Mon, 8 Feb 2021 23:29:27 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f51.google.com with SMTP id m1so622383wml.2 for ; Mon, 08 Feb 2021 15:29:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YC4SFofFhQ9SupdVQl801TjgDZ7rUL45lUr2yhY5j3E=; b=CH3o39Lv10d7OYcBEOipWjY1TTyx8PGaj2Elx/1NDOcvsb6DaXyTlbhYuB34e4LQa3 hsWG5U74kSSVUUw4L6IgvTJ1XFPdzIlZLxUn+H9SVadZO9vZDFH6XW/uJNgyWTThjKAc sgRmEEs8e4e8bYnvUS3twYGe04J/TK0+MNdOPdkGc4rjNmjlJdLz6EGwRVoFROwCWZVN vlB5POlubVNNdoA+SDszENZuqz++wYJKmuUQ2eVEzHMt6RmWmb0bfT8RyenvC/3G7HG7 lRD5FMMXUKrc4CXkmvk5B+fKQsy2T8uiyQe0QLuyiSLmfw5xVf1c8Khu9hTRqZxnyNxY RJVQ== X-Gm-Message-State: AOAM532HmEEgjfJPCNzO2SrM+Utt2988FTVGhxyrA4jUYXVgOH6Y1rEm GyS8+LeeDQre58yykgomjFRkSg== X-Google-Smtp-Source: ABdhPJwSzugale/3OUBOK4a551dBkmBKwutlQNst+vn5kYzNQRR9IrUdCmZje6wFniTrcb+XAmXsCg== X-Received: by 2002:a1c:29c6:: with SMTP id p189mr932614wmp.110.1612826966536; Mon, 08 Feb 2021 15:29:26 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id s23sm1094402wmc.35.2021.02.08.15.29.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Feb 2021 15:29:26 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 81e074d57dfc - main - libkern: use compiler builtins for strcpy, strcmp and strlen From: Jessica Clarke In-Reply-To: Date: Mon, 8 Feb 2021 23:29:25 +0000 Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202102081915.118JFVS0067851@gitrepo.freebsd.org> <8F5A406F-FB06-4D52-8CD7-1DCE01B6C126@freebsd.org> To: Alexander Richardson , Mateusz Guzik X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DZMgC6qSqz3KKT X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 23:29:28 -0000 On 8 Feb 2021, at 22:08, Alexander Richardson = wrote: >=20 > On Mon, 8 Feb 2021, 19:37 Jessica Clarke, wrote: >> On 8 Feb 2021, at 19:15, Mateusz Guzik wrote: >> >=20 >> > The branch main has been updated by mjg: >> >=20 >> > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D81e074d57dfcd86f152e2848dc44b770= 87ee7a2d >> >=20 >> > commit 81e074d57dfcd86f152e2848dc44b77087ee7a2d >> > Author: Mateusz Guzik >> > AuthorDate: 2021-02-07 19:50:25 +0000 >> > Commit: Mateusz Guzik >> > CommitDate: 2021-02-08 19:15:21 +0000 >> >=20 >> > libkern: use compiler builtins for strcpy, strcmp and strlen >>=20 >> Why? >=20 >=20 > I guess because the kernel uses -ffreestanding, so the libcall = inlining optimization requires explicit uses of __builtin_foo That would make sense, but such info belongs in the commit message, a comment or both... As it stands the message is not useful as anyone can see from reading the diff that that's what it does. Jess