From nobody Sat Oct 14 01:08:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6lcx4K9Gz4x3s9; Sat, 14 Oct 2023 01:08:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6lcx3cfnz3XZn; Sat, 14 Oct 2023 01:08:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697245729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Iz4yJnVv6KEvr8k1vjBr4tuICnAhRj/Emf1Nm679QMA=; b=VlEgdAWUJzTfuNSlSv66xElIoxRJbMK2tQ8/P/L2ZtHFSVMfxPbBuXM0d+Jiz9aM7qnzMg KnaC1vY1Id8P4curNbAAJwRwtmtwdRE+qRgFkj/2CB5M2C1nmSdpwz7aoN/wW2cre0AXac zblySi3SbWwO+lKAfxdblMcdSua1LR+h+I6+OmVL40oLR8h231/TMR/FbFFK4w8cRJl27U LBaF4CgNjVjYDlC6A7dNpG9LO/YCR5WfzsQJS0t+Sn4DTXVLwfOp7oWxDMJzgM2z+UqJL0 9zOa0qwmUdX6nV9OVD81xlutH3A2sau+DaFqZKyf5oiyvH4o7iJzNnPhGAErpg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697245729; a=rsa-sha256; cv=none; b=JF7VS4HWD/X1mFvC8dXnix3O9r5B0ArZgpfAJKCr4UC4pOvg0UvN+B03qAdLS4BO5Yjb0B B6duCHhtG254ou1IwT4ssUOfQUisK3fbtlT74YDpDpeZBt/BquCLlLSGlk/3RzHabotGi3 fEjH9JJTe/oOxwEzxVKKFhdiU6td+RcCjO6MPyUUQAAJi+QEe259aJaWXLyww+cBEAbvmM FBsDaSHpsm1W7MqUJsuFVUJ54UXDWF1vFy777RvACL6p9YJlR76KHk6xy/tkgMAnO+Bd6v 5efk2Ddii+UW6zuK7JjGvdzzptPzjq/nvOQpL8jpYB5lUg4LchWaWR95Hj1xxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697245729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Iz4yJnVv6KEvr8k1vjBr4tuICnAhRj/Emf1Nm679QMA=; b=tfxXz+NXlU136GEbtMm9oFEa/1zxdKn/pel7GdiCr8wKptBSh+VrQpNb53EvpXf1v6/nyA iMU8iUCIRH2IYy6OfNr2ZcM+aUq78whtZkwjDwdfoZV4kCVdnhuCpOJC9+AiWKQAH3mX90 gSZcfdFTF9lHW6rlv+rKuUfHbbD08kPY81rEeKg0g8cbbBkb790jj7qlX/ZBrHASG+Hbwb wsX6FDbUf/mSsXRjhCLwr1X5MB0z3y65PUWb64xcJQJLe1Wyz8/rdGhTOeEMfixcFy5hnU 1xz/aAKVpC+P2Xr/buhBitMPJ8XUi1QOmXb30aBIgxSk66dLeoXjFLVIQ3ViXA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6lcx2g09z19Sm; Sat, 14 Oct 2023 01:08:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39E18nCd052243; Sat, 14 Oct 2023 01:08:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39E18nSi052240; Sat, 14 Oct 2023 01:08:49 GMT (envelope-from git) Date: Sat, 14 Oct 2023 01:08:49 GMT Message-Id: <202310140108.39E18nSi052240@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: a1d54f986368 - releng/14.0 - vfs cache: denote a known bug in cache_remove_cnp List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: a1d54f98636833a512db69bfa765f1da0a011cb0 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=a1d54f98636833a512db69bfa765f1da0a011cb0 commit a1d54f98636833a512db69bfa765f1da0a011cb0 Author: Mateusz Guzik AuthorDate: 2023-10-05 12:32:29 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-14 01:06:47 +0000 vfs cache: denote a known bug in cache_remove_cnp (cherry picked from commit cd2105d691f446f7dbddf5965d82b9e9103bc8d2) (cherry picked from commit 99bfb6998b00ac8edd1395d76d199ddee62d24a0) Approved by: re (gjb) --- sys/kern/vfs_cache.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 0467619fe5d5..bd9eac69bfcb 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -1747,6 +1747,15 @@ retry_dotdot: return (1); } + /* + * XXX note that access here is completely unlocked with no provisions + * to keep the hash allocated. If one is sufficiently unlucky a + * parallel cache resize can reallocate the hash, unmap backing pages + * and cause the empty check below to fault. + * + * Fixing this has epsilon priority, but can be done with no overhead + * for this codepath with sufficient effort. + */ hash = cache_get_hash(cnp->cn_nameptr, cnp->cn_namelen, dvp); blp = HASH2BUCKETLOCK(hash); retry: